Add JS library #4
Conversation
There was a problem hiding this comment.
It's generated from TS code
There was a problem hiding this comment.
i suppose these need to be defined still?
There was a problem hiding this comment.
Generated code
| const HyperTrack = (function () { | ||
| return hyperTrackInstance; | ||
| })(); |
There was a problem hiding this comment.
Generated code
| var HyperTrackError; | ||
| (function (HyperTrackError) { |
There was a problem hiding this comment.
i suppose this PR is still wip, the error is already declared elsewhere if I read this correctly
There was a problem hiding this comment.
Generated code
| override fun onPause() { | ||
| super.onPause() | ||
| webView?.onPause() | ||
| } | ||
|
|
||
| override fun onResume() { | ||
| super.onResume() | ||
| webView?.onResume() | ||
| } | ||
|
|
||
| override fun onDestroy() { | ||
| webView?.destroy() | ||
| super.onDestroy() | ||
| } |
There was a problem hiding this comment.
why do we sometimes call we view before super and vice versa?
There was a problem hiding this comment.
We need to destroy the view before everything else is destroyed (I am not sure why, it's just seems to be more correct way)
There was a problem hiding this comment.
yeah i get that, but why not always call the view first before the super then?
pavel-kuznetsov-hypertrack
force-pushed
the
add-js-library
branch
from
f986242 to
e52ff2e
Compare
Add JS library wrapper around WebView Java-JS interface for users to be able to properly call HyperTrack SDK from WebView JS code