Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hamamatsu tiff reader if x axis not calibrated #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jlaehne
Copy link
Member

@jlaehne jlaehne commented Dec 16, 2024

Description of the change

Fixes reading error when Hamamatsu tiff file contains ScalingXScalingFile="Other" and not an address in the file (not calibrated axis).

Progress of the PR

  • Change implemented (can be split into several points),
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • add tests,
  • ready for review.

Minimal example of the bug fix or the new feature

from rsciio.tiff import file_reader
file_reader("hamamatsu.tiff")
# Your new feature...

@jlaehne jlaehne added this to the v0.7 milestone Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (4e67875) to head (a3d2f8b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          85       85           
  Lines       11242    11246    +4     
  Branches     2082     2084    +2     
=======================================
+ Hits         9875     9879    +4     
  Misses        868      868           
  Partials      499      499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaehne
Copy link
Member Author

jlaehne commented Dec 16, 2024

pre-commit.ci autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant