Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GitHub CI workflows by using reusable workflow #190

Merged
merged 6 commits into from
Dec 2, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 1, 2023

Similar to hyperspy/exspy#13.

Progress of the PR

  • Simplify GitHub CI workflows by using reusable workflow ,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d47be70) 86.17% compared to head (b2b80bf) 86.17%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files          82       82           
  Lines       10475    10475           
  Branches     2275     2275           
=======================================
  Hits         9027     9027           
  Misses        931      931           
  Partials      517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
fetch-depth: 0

- name: get repository name
shell: bash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I force push to add this line.

Suggested change
shell: bash
shell: bash

@ericpre ericpre merged commit db3ca53 into hyperspy:main Dec 2, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants