Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite #186

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Fix test suite #186

merged 4 commits into from
Nov 26, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Nov 25, 2023

Fix test suite following hyperspy/exspy#10 and .

Progress of the PR

  • Fix install exspy,
  • Fix failing because of missing dependencies, surprisingly it wasn't caught in Fix test suite without optional dependencies #182
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • update tests,
  • ready for review.

@ericpre ericpre added this to the v0.3 milestone Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (ecf3d0f) 85.78% compared to head (3ff5c38) 86.02%.
Report is 7 commits behind head on main.

Files Patch % Lines
rsciio/emd/_emd_velox.py 84.02% 35 Missing and 30 partials ⚠️
rsciio/emd/_emd_ncem.py 92.11% 9 Missing and 10 partials ⚠️
rsciio/emd/_api.py 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   85.78%   86.02%   +0.23%     
==========================================
  Files          79       81       +2     
  Lines       10365    10387      +22     
  Branches     2180     2253      +73     
==========================================
+ Hits         8892     8935      +43     
+ Misses        950      931      -19     
+ Partials      523      521       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rsciio/tests/test_import.py Dismissed Show dismissed Hide dismissed
@ericpre ericpre merged commit 13507d4 into hyperspy:main Nov 26, 2023
31 checks passed
@ericpre ericpre deleted the fix_test_suite branch December 1, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant