Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releasing guide and release script #59

Merged
merged 2 commits into from
May 6, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented May 4, 2024

No description provided.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.01%. Comparing base (4d45bec) to head (82c01b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files           9        9           
  Lines        1216     1216           
  Branches      113      113           
=======================================
  Hits          973      973           
  Misses        228      228           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre force-pushed the add_releasing_guide branch from c01688c to 82c01b6 Compare May 4, 2024 07:44
@ericpre ericpre requested a review from jlaehne May 4, 2024 07:46
Comment on lines +7 to +10
def run_towncrier(tag):
cmd = ("towncrier", "build", "--version", tag.strip("v"))

return subprocess.call(cmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem to be using towncrier so far

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for leaving the script as it is but commented out the call to this function in the __main__ block.

@ericpre ericpre merged commit 9c5a131 into hyperspy:main May 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants