Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding plugins for doing processing of differential phase contrast datasets #134

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Adding plugins for doing processing of differential phase contrast datasets #134

wants to merge 16 commits into from

Conversation

magnunor
Copy link
Contributor

@magnunor magnunor commented Apr 17, 2017 •
edited
Loading

Adding plugins for doing processing of differential phase contrast datasets.

The plugins made in #122, #123, #124, #125 and #126 has been combined into a single file.

  • Add unit tests
  • Make the record functionality work
  • Better documentation
  • Fix comments from last pull requests

@magnunor
Add DPC plugin for FFT filtering a beam shift image
a6cef85
@magnunor
Improve DPC FFT masking plugin
e0b1e5c
@magnunor
Add DPC plugin for getting a bivariate histogram of the beam shifts
0d7a441
@magnunor
Add DPC plugin for making a color image from beam shift signals
28826d3
@magnunor
Add DPC plugin for removing the effects of d-scan
82e7eed
@magnunor
Add plugin for calculating DPC beam shifts from segmented detector
87ea088
@magnunor
Improve DPC beam shift from segmented plugin
b2cf8ed
@magnunor
Combine DPC plugins into a single file
e1209d8
@magnunor
Change order of plugins in DPC menu to follow a natural workflow
af12534
@magnunor
DPC plugins: if signal selection is cancelled, do not run rest of code
a1bd850
@magnunor
DPC plugins: precalculate values in bivariate histogram
12bf4b6
@magnunor
DPC plugins, subtract background: if no signal is specified, stop plugin
4b0611f
@magnunor
DPC plugins: make all actions work without prompting the user for input
b2d07c6 
This enables unit tests and recording(?)
@magnunor
Copy link
Contributor Author

Any good examples on how to make the recording functionality work?

@vidartf
Copy link
Member

vidartf commented Apr 17, 2017

Looking at the code, I'm not entirely sure how to best record as code: Almost all your entry points start off with select_x_signals which is hard to record well as a macro code. Maybe it is best to simply leave it out, and have the user rely on recorded actions?

@magnunor
Copy link
Contributor Author

Added unit tests for the processing itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnunor @vidartf