Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use towncrier and improve setting dev version #14

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 1, 2023

Similar as hyperspy/holospy#17

Progress of the PR

  • Improve setting development version,
  • Use towncrier to manage release notes,
  • [n/a] docstring updated (if appropriate),
  • update user guide (if appropriate),
  • added tests,
  • added line to CHANGES.rst,
  • ready for review.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (add7440) 88.09% compared to head (1b4a709) 88.09%.

Files Patch % Lines
exspy/__init__.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   88.09%   88.09%   -0.01%     
==========================================
  Files          67       67              
  Lines        7284     7289       +5     
  Branches     1175     1176       +1     
==========================================
+ Hits         6417     6421       +4     
  Misses        593      593              
- Partials      274      275       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

exspy/__init__.py Outdated Show resolved Hide resolved
exspy/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amend PULL_REQUEST_TEMPLATE.md as for holospy?

@ericpre
Copy link
Member Author

ericpre commented Dec 2, 2023

Amend PULL_REQUEST_TEMPLATE.md as for holospy?

Done!

@ericpre ericpre merged commit e8a5147 into hyperspy:main Dec 2, 2023
15 of 17 checks passed
@ericpre ericpre added this to the v0.1 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants