Keeping an image, downloaded from Internet, for future use #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ox has downloaded an image via URL (again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if you add an image inited from an UIImage this way:
LightboxImage(image: UIImage(named: "photo1")!, text: "This is an example of a remote image loaded from URL")it is going to be accessible via
lightbox.[pageNumber].image.However, this property is going to be nil if you init an image from a URL this way:
LightboxImage(imageURL: URL(string: "https://cdn.arstechnica.net/2011/10/05/iphone4s_sample_apple-4e8c706-intro.jpg")!)This is a regression, because it has already been fixed long time ago in PR #122
This PR fixes it and makes the image to be accessible again via
lightbox.[pageNumber].imagein case it is inited as URL, assuming user has opened it and it was loaded.