Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeAgent): KID will be present on any signed JWTs #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(edgeAgent): KID will be present on any signed JWTs #170

wants to merge 2 commits into from

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Sep 23, 2024 •
edited
Loading

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
Copy link
Contributor

carefull with DCO please but looks good!

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/OIDC-Preparation-Refactoring branch 2 times, most recently from 80571a6 to 65ff99d Compare September 25, 2024 14:40
Base automatically changed from feature/OIDC-Preparation-Refactoring to main September 26, 2024 09:48
@goncalo-frade-iohk
feat(agent): agent separation of concerns
c1164b4 
This is a refactor, from now on the EdgeAgent will not have any reference with DIDComm and a DIDCommAgent will replace this.
EdgeAgent now will scope all the logic that is inherent to it removing any transport layer association, and new agents like DIDCommAgent will scope the EdgeAgent functionalities for a transport layer.

With this Pollux also has some significant changes so it is not aggregated to the DIDComm Message.

OIDCAgent will take part of OIDC transport layer communication.

Signed-off-by: goncalo-frade-iohk <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11161856229

Details

  • 39 of 66 (59.09%) changed or added relevant lines in 12 files are covered.
  • 213 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-1.7%) to 40.971%
Changes Missing Coverage Covered Lines Changed/Added Lines %
EdgeAgentSDK/Apollo/Sources/Model/Ed25519Key.swift 0 1 0.0%
EdgeAgentSDK/Apollo/Sources/Model/X25519Key.swift 0 1 0.0%
EdgeAgentSDK/Apollo/Sources/Model/Secp256k1Key.swift 2 4 50.0%
EdgeAgentSDK/Apollo/Sources/Operations/CreateX25519KeyPairOperation.swift 2 4 50.0%
EdgeAgentSDK/Apollo/Sources/Operations/CreateEd25519KeyPairOperation.swift 0 4 0.0%
EdgeAgentSDK/Pollux/Sources/Operation/JWT/CreateJWTCredentialRequest.swift 0 7 0.0%
EdgeAgentSDK/Apollo/Sources/ApolloImpl+Public.swift 14 24 58.33%
Files with Coverage Reduction New Missed Lines %
EdgeAgentSDK/Domain/Sources/Models/Message+Codable.swift 1 89.74%
EdgeAgentSDK/Apollo/Sources/Operations/CreateX25519KeyPairOperation.swift 3 81.48%
EdgeAgentSDK/Apollo/Sources/Operations/CreateEd25519KeyPairOperation.swift 3 26.92%
EdgeAgentSDK/Domain/Sources/AnyCodable.swift 4 31.98%
EdgeAgentSDK/EdgeAgent/Sources/DIDCommAgent/DIDCommAgent.swift 5 34.53%
EdgeAgentSDK/Apollo/Sources/ApolloImpl+Public.swift 5 65.09%
EdgeAgentSDK/Castor/Sources/Resolvers/PeerDIDResolver.swift 20 45.61%
EdgeAgentSDK/Domain/Sources/Models/DIDDocument.swift 28 43.69%
EdgeAgentSDK/EdgeAgent/Sources/DIDCommAgent/DIDCommAgent+Invitations.swift 32 31.71%
EdgeAgentSDK/Domain/Sources/Models/MessageAttachment.swift 33 20.0%
Totals Coverage Status
Change from base Build 11052319165: -1.7%
Covered Lines: 5259
Relevant Lines: 12836
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @elribonazo @coveralls