Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pollux): add sdjwt verifier flow #161

Merged
merged 2 commits into from
Aug 26, 2024
Merged

feat(pollux): add sdjwt verifier flow #161

merged 2 commits into from
Aug 26, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Aug 17, 2024 •
edited
Loading

Description:

Now the SDK can as a verifier request presentation of a sdjwt and verify all the claims.

Fixes ATL-6865

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@goncalo-frade-iohk
feat(pollux): add sdjwt verifier flow
ff403aa 
Now the SDK can as a verifier request presentation of a sdjwt and verify all the claims.

Fixes ATL-6865

Signed-off-by: goncalo-frade-iohk <[email protected]>
@coveralls
Copy link

coveralls commented Aug 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10506847036

Details

  • 335 of 431 (77.73%) changed or added relevant lines in 20 files are covered.
  • 41 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 44.056%
Changes Missing Coverage Covered Lines Changed/Added Lines %
EdgeAgentSDK/Pollux/Sources/Models/JWT/JWTCredential+ProofableCredential.swift 0 1 0.0%
EdgeAgentSDK/Pollux/Sources/Operation/PresentationExchange/SubmissionDescriptorParser.swift 16 17 94.12%
EdgeAgentSDK/Pollux/Sources/Models/SDJWT/SDJWTPresentation.swift 51 53 96.23%
EdgeAgentSDK/Pollux/Sources/Operation/JWT/JWTPresentationExchangeParser.swift 23 26 88.46%
EdgeAgentSDK/Pollux/Sources/Operation/JWT/VerifyJWT.swift 30 33 90.91%
EdgeAgentSDK/Pollux/Sources/Operation/SDJWT/VerifySDJWT.swift 42 45 93.33%
EdgeAgentSDK/Pollux/Sources/PolluxImpl+CredentialVerification.swift 20 23 86.96%
EdgeAgentSDK/Pollux/Sources/Operation/PresentationExchange/VerifyJsonClaim.swift 59 63 93.65%
EdgeAgentSDK/Pollux/Sources/Operation/PresentationExchange/VerifyPresentationSubmission.swift 42 46 91.3%
EdgeAgentSDK/Domain/Sources/Models/Errors.swift 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
EdgeAgentSDK/Pollux/Sources/PolluxImpl+CredentialVerification.swift 41 56.28%
Totals Coverage Status
Change from base Build 10475918581: 0.6%
Covered Lines: 5329
Relevant Lines: 12096
💛 - Coveralls

cristianIOHK
cristianIOHK approved these changes Aug 20, 2024
View reviewed changes
Copy link

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@goncalo-frade-iohk goncalo-frade-iohk merged commit 7e2737c into main Aug 26, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/atl-6865 branch August 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@curtis-h curtis-h Awaiting requested review from curtis-h

@elribonazo elribonazo Awaiting requested review from elribonazo elribonazo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @coveralls @cristianIOHK