Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anoncreds): add support for anoncreds issuance flow #103

Merged
merged 1 commit into from
Oct 12, 2023
Merged

feat(anoncreds): add support for anoncreds issuance flow #103

merged 1 commit into from
Oct 12, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Oct 9, 2023 •
edited
Loading

Overview

Add support for anoncreds issuance

Fixes ATL-4294

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to the above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to the above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to the above: I have added tests to cover my changes
  • If yes to the above: I have taken care to cover edge cases in my tests

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-4294 branch 2 times, most recently from 43e52f3 to 0c54fd0 Compare October 12, 2023 12:46
curtis-h
curtis-h approved these changes Oct 12, 2023
View reviewed changes
AtalaPrismSDK/Pollux/Sources/PolluxImpl+CredentialRequest.swift Outdated
@@ -17,18 +17,23 @@ extension PolluxImpl {
throw PolluxError.offerDoesntProvideEnoughInformation
}

switch offerAttachment.mediaType {
switch offerAttachment.format {
case "jwt", "", .none:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking has this been tested? I thought the jwt cred-offer had a format of "prism/jwt"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a nice catch. I actually tested and worked on this morning but it didn't went on the commit my mistake. Updated now its solved ;)

cristianIOHK
cristianIOHK approved these changes Oct 12, 2023
View reviewed changes
Copy link

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@goncalo-frade-iohk goncalo-frade-iohk merged commit 579c603 into main Oct 12, 2023
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-4294 branch October 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtis-h curtis-h curtis-h approved these changes

@cristianIOHK cristianIOHK cristianIOHK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalo-frade-iohk @curtis-h @cristianIOHK