Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docs for agent env variables #50

Merged
merged 4 commits into from
Aug 25, 2023
Merged

feat: add docs for agent env variables #50

merged 4 commits into from
Aug 25, 2023

Conversation

shotexa
Copy link
Contributor

@shotexa shotexa commented Aug 21, 2023

Add docs for Prism agent environment variables.
URL is atala-prism/prism-cloud-agent/environment-variables

@shotexa shotexa self-assigned this Aug 21, 2023
antonbaliasnikov
antonbaliasnikov suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@antonbaliasnikov antonbaliasnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to ask ChatGPT to make a table from it to be more readable, what do you think?

bvoiturier
bvoiturier approved these changes Aug 22, 2023
View reviewed changes
Copy link

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

documentation/docs/atala-prism/prism-cloud-agent/environment-variables.md Outdated
* `CASTOR_DB_USER`
- Type: `String`
- Default: `postgres`
- Description: Castor databse username for login
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo on databse here and below.

@shotexa
Copy link
Contributor Author

shotexa commented Aug 24, 2023

I think it's better to ask ChatGPT to make a table from it to be more readable, what do you think?

I've changed it to a table, it looks like this now
image
Not ideal tbh but this is due to the long descriptions, The table is displayed this way. It is consistent with other pages tho, so I think we should leave it like that.

@antonbaliasnikov antonbaliasnikov changed the title docs(prism-agent): Add docs for agent env variables docs(prism-agent): add docs for agent env variables Aug 25, 2023
@antonbaliasnikov antonbaliasnikov changed the title docs(prism-agent): add docs for agent env variables feat: add docs for agent env variables Aug 25, 2023
@antonbaliasnikov antonbaliasnikov merged commit ff926ba into main Aug 25, 2023
6 checks passed
@antonbaliasnikov antonbaliasnikov deleted the ATL-5505-docs-for-prism-agent branch August 25, 2023 13:48
atala-dev added a commit that referenced this pull request Aug 25, 2023
@atala-dev
chore(release): release prism documentation portal 1.46.0
93d65c0 
## [1.46.0](v1.45.0...v1.46.0) (2023-08-25)

### 🚀 New Content

* add docs for agent env variables ([#50](#50)) ([ff926ba](ff926ba))
@yshyn-iohk yshyn-iohk mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbaliasnikov antonbaliasnikov antonbaliasnikov approved these changes

@bvoiturier bvoiturier bvoiturier approved these changes

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk yshyn-iohk is a code owner

Assignees

@shotexa shotexa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shotexa @bvoiturier @antonbaliasnikov