feature: add publicKey to PrivateKeys #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianIOHK
requested review from
elribonazo,
hamada147 and
goncalo-frade-iohk
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ EDITORCONFIG | editorconfig-checker | 5 | 0 | 0.01s | |
| ✅ KOTLIN | ktlint | 5 | 0 | 15.78s | |
| devskim | yes | 6 | 1.09s | ||
| ✅ REPOSITORY | dustilock | yes | no | 0.14s | |
| ✅ REPOSITORY | gitleaks | yes | no | 1.8s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.05s | |
| ✅ REPOSITORY | secretlint | yes | no | 5.46s | |
| ✅ REPOSITORY | syft | yes | no | 0.35s | |
| ✅ REPOSITORY | trivy | yes | no | 7.14s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by
hamada147
approved these changes
Sep 27, 2023
4 tasks
elribonazo
added a commit
that referenced
this pull request
Oct 4, 2023
…rism-apollo into feature/ATL-5687 * 'feature/ATL-5687' of github.com:input-output-hk/atala-prism-apollo: fix: deployment script (#101) build: increase gradle version 1.0.2 (#100) feat(BAE): updating jsMain Ed25519 keys for use in TS (#92) fix: constructor and access to some methods were missing in ios (#93) fix: bugs found while integrating apollo with KMP SDK (#98) fix: KMP Gradle bug (#99) build: increase gradle version 1.0.1 (#97) feature: add publicKey to PrivateKeys (#96) feat: compress and uncompress secp256k1 functionality for (macos,ios,js,android,jvm) (#95) feat: add mnemonic validation (#94) # Conflicts: # base-asymmetric-encryption/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMECSecp256k1PublicKey.kt
hamada147
added a commit
that referenced
this pull request
May 20, 2024
Co-authored-by: Ahmed Moussa <[email protected]> Signed-off-by: Cristian G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private keys classes missing publicKey method for jvm and android.