add test for caliper-engine module #1638
Conversation
Signed-off-by: Babatunde Sanusi <[email protected]>
tunedev
force-pushed
the
add-test-to-manager-caliper-engine-module
branch
from
05f794e
to
bf0217f
Compare
| // TODO: Implement test | ||
| }); | ||
|
|
||
| it('should handle cases where the round orchestrator is not running', function() { |
There was a problem hiding this comment.
This text should be explicit about what it is testing. So in this case please use
should do nothing if no benchmark run has been started
Whether a benchmark run has been started can be tested in 2 ways
- the run method has not been called
- the run method has been called but performTest was not set to true
| }); | ||
|
|
||
| describe('Stop Method Functionality', function() { | ||
| it('should stop the round orchestrator if it is running', function() { |
There was a problem hiding this comment.
we can be more explicit here
should stop the benchmark if the benchmark has been started
this test should find a bug
| }); | ||
|
|
||
| context('When end commands are to be executed', function() { | ||
| it('should execute the end command successfully', function() { |
There was a problem hiding this comment.
end commands are always run if the flag is set to true, even if an error occurs on any of the other stages. This scenario needs to be tested
| }); | ||
| }); | ||
|
|
||
| describe('Run Method Execution Flow', function() { |
There was a problem hiding this comment.
Still don't like putting implementation details in the test so please change this. This section is about when a benchmark is run
| }); | ||
| }); | ||
|
|
||
| describe('Stop Method Functionality', function() { |
There was a problem hiding this comment.
Again, I don't like to see implementation details. This section is about when a request to stop a benchmark is made
Checklist
Issue/User story
Closes #1637
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
Automated Tests
What documentation has been provided for this pull request