Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more test for fixedFeedbackRate controller implementation #1628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tunedev
Copy link
Contributor

@tunedev tunedev commented Sep 11, 2024

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Partially addresses #1606

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed

  • caliper-core/lib/worker/fixedFeedbackRate.js: 80

Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before

  • caliper-core/lib/worker/fixedFeedbackRate.js: 60

What documentation has been provided for this pull request

@tunedev tunedev requested a review from a team as a code owner September 11, 2024 07:00
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is going to be a hard one to test and make sure that the descriptions of the tests provide detail. Unfortunately the original tests are not ideal either but I don't think we should follow the same pattern as this file if we know they are not ideal. If possible it would be nice to update them but I think that would have to be an exercise for later.

However I saw you correctly used async/await in your tests and the original ones didn't, so a quick update worth doing would be to apply that pattern to the original tests.

@tunedev tunedev force-pushed the add-more-test-for-fixedFeedbackRate branch from 16508ec to 2eec183 Compare September 27, 2024 11:10
@tunedev tunedev requested a review from davidkel October 8, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants