Warm up to address at tx start if account is delegated, restrict auth nonce #7717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nonce to 2**64-1 Signed-off-by: Daniel Lehrner <[email protected]>
macfarla
reviewed
Oct 3, 2024
| .build(); | ||
| } else { | ||
| @SuppressWarnings("OptionalGetWithoutIsPresent") // isContractCall tests isPresent | ||
| final Address to = transaction.getTo().get(); | ||
| final Optional<Account> maybeContract = Optional.ofNullable(evmWorldUpdater.get(to)); | ||
|
|
||
| if (maybeContract.isPresent() && maybeContract.get().hasDelegatedCode()) { | ||
| warmAddressList.add(to); |
There was a problem hiding this comment.
would be great to have a test for this
3 tasks
…compile always as warm account when resolving code Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes a missing gas calculation when the
toaddress of a tx has delegated code. The address needs to be warmed up at the beginning of the tx.The auth of the nonce was before resticted to be less or equal than 264-1, but now must be less than 264-1 to avoid overflows. That is the same restriction that tx nonces already have.
Fixed Issue(s)
fixes #7706
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests