Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and publish Besu BOM (Bill of Materials) #7615

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Sep 13, 2024

PR description

Introducing Besu BOM (bill of materials) to improve the way we manage shared dependencies between Besu and plugins.
It is based on Gradle Java Platform plugin and it is also used internally, replacing the Spring Dependency Manager, it is then published as BOM artifacts so it can be used as reference in plugins for all the dependencies that are in common with Besu, this way it is easier to spot dependencies incompatibilities when developing plugins.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 marked this pull request as ready for review September 17, 2024 12:45
@garyschulte
Copy link
Contributor

This looks clean, but could you provide a description and motivation for the change?

@fab-10
Copy link
Contributor Author

fab-10 commented Sep 18, 2024

Thanks @garyschulte, I just forgot to add it, done now.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just couple of questions...

Does this PR have any impact on the license report?

besu/build.gradle

Lines 113 to 114 in 0d63955

// If set to true, then all boms will be excluded from the report
excludeBoms = true

platform/build.gradle Show resolved Hide resolved
gradle/versions.gradle Show resolved Hide resolved
@fab-10
Copy link
Contributor Author

fab-10 commented Sep 24, 2024

Looks good, just couple of questions...

Does this PR have any impact on the license report?

besu/build.gradle

Lines 113 to 114 in 0d63955

// If set to true, then all boms will be excluded from the report
excludeBoms = true

I have checked and the licenses are checked and the report is produced as before.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for answering my questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants