Constantine bindings for EIP196 #184

NickSneo · 2024-06-27T04:19:28Z

Fixes
hyperledger/besu#7242
#195
hyperledger/besu#7243

Signed-off-by: Nischal Sharma <[email protected]>

garyschulte · 2024-06-27T22:31:05Z

👀

just a tracking comment

mratsim

There shouldn't be a need for indirection and allocation, the function can be called and write directly in the relevant buffer, see C, Rust and Go code as referemce.

Also is optimizing for ARM desirable?

On non-x86 Constantine compiles through uint128 as it's the most portable and best perf across all compilers. Both GCC and Clang support an add with overflow called __builtin__addcll but the perf is abysmal on GCC: https://gcc.godbolt.org/z/jdecvffaP see overall issue mratsim/constantine#357

I do have a plan for optimizing for ARM targets (see mratsim/constantine#200 ) but so far no time to tackle it.

cc @Vindaar as well as he is currently maintaining the external languages dependencies.

mratsim · 2024-06-28T05:53:39Z

constantine/constantine_eip196_bindings.nim

+ var inputSeq: seq[byte] = cast[seq[byte]](inputs[0 ..< inputsLen])
+ let status = ethereum_evm_precompiles.eth_evm_bn254_g1add(result, inputSeq)
+ copyMem(r, addr result[0], rLen)
+ return status


There shouldn't be a need for this indirection and allocation.

If from Nim (ptr, length) pair can be zero-copied transformed to openarrays with https://nim-lang.org/docs/system.html#toOpenArray%2Cptr.UncheckedArray%5BT%5D%2Cint%2Cint

If from C, Go, Rust, you can directly call eth_evm_bn254_g1add
because it's compiled to (ptr, len):

see https://github.com/mratsim/constantine/blob/8db2639/include/constantine/protocols/ethereum_evm_precompiles.h#L98-L128

/** * Elliptic Curve addition on BN254_Snarks * (also called alt_bn128 in Ethereum specs * and bn256 in Ethereum tests) * * Name: ECADD * * Inputs: * - A G1 point P with coordinates (Px, Py) * - A G1 point Q with coordinates (Qx, Qy) * * Each coordinate is a 32-byte bigEndian integer * They are serialized concatenated in a byte array [Px, Py, Qx, Qy] * If the length is less than 128 bytes, input is virtually padded with zeros. * If the length is greater than 128 bytes, input is truncated to 128 bytes. * * Output * - Output buffer MUST be of length 64 bytes * - A G1 point R = P+Q with coordinates (Rx, Ry) * - Status code: * cttEVM_Success * cttEVM_InvalidOutputSize * cttEVM_IntLargerThanModulus * cttEVM_PointNotOnCurve * * Spec https://eips.ethereum.org/EIPS/eip-196 */ ctt_evm_status ctt_eth_evm_bn254_g1add( byte* r, ptrdiff_t r_len, const byte* inputs, ptrdiff_t inputs_len ) __attribute__((warn_unused_result));

See how to call SHA256 from C (same interface):
https://github.com/mratsim/constantine/blob/8db2639/examples-c/ethereum_evm_precompiles.c#L47-L51

byte result[32] = {0}; const char txt[] = "Foo, Bar and Baz are all friends."; evm_status = ctt_eth_evm_sha256(result, 32, (const byte*)txt, sizeof(txt));

Rust slices to Nim with zero-copy or alloc:
https://github.com/mratsim/constantine/blob/8db2639/constantine-rust/constantine-ethereum-evm-precompiles/src/lib.rs#L53-L69

pub fn evm_bn254_g1add( result: &mut [u8], inputs: &[u8] ) -> Result<bool, ctt_evm_status> { unsafe { let status = ctt_eth_evm_bn254_g1add( result.as_mut_ptr() as *mut byte, result.len() as isize, inputs.as_ptr() as *const byte, inputs.len() as isize, ); match status { ctt_evm_status::cttEVM_Success => Ok(true), _ => Err(status) } } }

Go slices to Nim with zero-copy or alloc:
https://github.com/mratsim/constantine/blob/8db2639/constantine-go/constantine.go#L705-L718

func EvmBn254G1Mul(result []byte, inputs []byte) (bool, error) { status := C.ctt_eth_evm_bn254_g1mul((*C.byte)(getAddr(result)), (C.ptrdiff_t)(len(result)), (*C.byte)(getAddr(inputs)), (C.ptrdiff_t)(len(inputs)), ) if status != C.cttEVM_Success { err := errors.New( C.GoString(C.ctt_evm_status_to_string(status)), ) return false, err } return true, nil }

One thing is that in an excess zeal moment I set the type to ptrdiff_t but I'll change it to size_t.

In general Constantine was written to minimize allocations and for precompiles it's only needed for MSMs and KZG point precompiles.

Hey @mratsim Thanks for the inputs, I have been working on a new approach based on your inputs, taking inspiration from example c code.
ethereum_evm_precompiles.nim -> compile into shared library -> Create C Bindings: ethereum_evm_precompiles.c -> Define Java Native Methods -> Compile and Run

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo · 2024-07-12T07:45:11Z

@garyschulte @mratsim Pushed some new commits, I shall be removing the files inside constantine/constantine-jni/lib/ folder
and planning to compile constantine lib using gradle task and use those files directly.
The PR is still in draft but can you review to check my approach is I am going in correct direction.

Thanks

constantine/build.gradle

constantine/constantine-jni/lib/libconstantine.a

constantine/constantine-jni/src/main/c/ethereum_evm_precompiles.c

mratsim · 2024-07-12T09:44:05Z

constantine/constantine-jni/src/main/c/ethereum_evm_precompiles.c

+
+JNIEXPORT jint JNICALL Java_Constantine_ctt_1eth_1evm_1bn254_1g1add(JNIEnv *env, jobject obj, jbyteArray jr, jint r_len, jbyteArray jinputs, jint inputs_len) {
+ jbyte *r = (*env)->GetByteArrayElements(env, jr, NULL);
+ jbyte *inputs = (*env)->GetByteArrayElements(env, jinputs, NULL);


Unfortunately I'm not familiar with Java at all but it seems like what is also being done in c-kzg-4844 so it's likely the expected way to wrap:

https://github.com/ethereum/c-kzg-4844/blob/1bccee0878ffc80efe8741afdb5793ef9105aa35/bindings/java/c_kzg_4844_jni.c#L148-L179

garyschulte · 2024-07-15T21:40:43Z

constantine/constantine-jni/src/main/c/ethereum_evm_precompiles.c

+ jbyte *r = (*env)->GetByteArrayElements(env, jr, NULL);
+ jbyte *inputs = (*env)->GetByteArrayElements(env, jinputs, NULL);
+
+ ctt_evm_status status = ctt_eth_evm_bn254_g1mul((byte *)r, (ptrdiff_t)r_len, (const byte *)inputs, (ptrdiff_t)inputs_len);


very tidy that constantine already has precompile friendly endpoints 👍 . Is this the same for eip2537?

Yes, and SHA256 and MODEXP. The plan is to implement all cryptographic precompiles.

For the record, Constantine was actually started with the idea of having a clean from scratch BN254 backend for Nim but it was too hard/time-consuming at the time so a 1-1 port of https://github.com/zcash-hackworks/bn was made instead (https://github.com/status-im/nim-bncurve).
However performance is bad as even a simple add with carry instruction is transformed into 7 instructions: https://github.com/zcash-hackworks/bn/blob/master/src/arith.rs#L396-L405

The issue of zcash's bn were already mentioned in 2008 in EIP-1108 https://eips.ethereum.org/EIPS/eip-1108 that reduced gas cost price. And moving to Cloudflare bn256 improved speed by 10x:

and corroborated in a later note, the computational cost of ECADD, ECMUL, and pairing checks (excepting the constant) has dropped roughly an order of magnitude across the board.

However that Cloudflare library was about 2x slower than state-of-the-art in 2021 https://hackmd.io/@gnark/eccbench
https://user-images.githubusercontent.com/22738317/162632923-b057c0a2-6929-419e-b0de-4fd187a5e508.png
and Constantine there had a parameter passing bug which made it 2x slower than necessary on pairings (nim-lang/Nim#16897)

See full context in https://ethresear.ch/t/releasing-constantine-v0-1-0-a-modular-cryptography-stack-for-ethereum/19990

garyschulte

This PR is looking good. A good next step would be to implement the EIP196 test cases that exist for the matter-labs and gnark-crypto implementations.

Much of the contract 'shim' implementation for the besu evm can be copied wholesale, including the test cases.

Edit: looking at the CI output, it looks like there is a problem loading the generated library in java.

garyschulte · 2024-07-15T21:59:58Z

constantine/build.gradle

+task compileJavaSource(type: Exec) {
+ description = 'Compiles the Java source files'
+ commandLine 'javac', 'src/main/java/org/hyperledger/besu/nativelib/constantine/LibConstantineEIP196.java'
+}
+
+task generateJNIHeader(type: Exec) {
+ description = 'Generates the JNI header file'
+ commandLine 'javac', '-h', 'constantine/constantine-jni/include', 'src/main/java/org/hyperledger/besu/nativelib/constantine/LibConstantineEIP196.java'
+}
+
+task compileNativeLibrary(type: Exec) {
+ description = 'Compiles the native library'
+ commandLine 'clang', '-I', "${System.env.JAVA_HOME}/include", '-I', "${System.env.JAVA_HOME}/include/darwin", '-shared', '-o', 'constantine-jni/lib/libconstantine.jnilib', 'constantine-jni/src/main/c/ethereum_evm_precompiles.c', '-I', 'constantine/include', '-I', 'src/main/java/org/hyperledger/besu/nativelib/constantine', '-L', 'constantine-jni/lib', '-lconstantine'
+}


Idiomatic besu-native builds incorporate the build of the library into the root build.sh script and use automake or a similar tool to ensure that the appropriate toolchain is configured (cc, gcc, clang, etc).

I think it is reasonable to use gradle for these tasks, but we should expect to be able to build on a variety of platforms.

also, adding a dependsOn chain between these dependent tasks will make for an easier build ux.

garyschulte

generally LGTM. some suggestions in comments. It would be helpful to add a README.md that describes the library, purpose, and build instructions (like installing nim, clang, etc as build dependencies).

The changes I suggested to build.gradle plus adding nim to the package installs here, here, and here portions of .github/workflows/build.yml should get things building properly in CI

constantine/build.gradle

NickSneo · 2024-07-16T23:19:22Z

This PR is looking good. A good next step would be to implement the EIP196 test cases that exist for the matter-labs and gnark-crypto implementations.

Much of the contract 'shim' implementation for the besu evm can be copied wholesale, including the test cases.

Edit: looking at the CI output, it looks like there is a problem loading the generated library in java.

Fixing it right now

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo · 2024-07-17T02:06:51Z

generally LGTM. some suggestions in comments. It would be helpful to add a README.md that describes the library, purpose, and build instructions (like installing nim, clang, etc as build dependencies).

The changes I suggested to build.gradle plus adding nim to the package installs here, here, and here portions of .github/workflows/build.yml should get things building properly in CI

This and adding tests from Gnark and matter-labs is remaining, working on them.

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo · 2024-07-17T16:43:58Z

This PR is looking good. A good next step would be to implement the EIP196 test cases that exist for the matter-labs and gnark-crypto implementations.

Much of the contract 'shim' implementation for the besu evm can be copied wholesale, including the test cases.

Edit: looking at the CI output, it looks like there is a problem loading the generated library in java.

Added test cases from Gnark Lib

Signed-off-by: Nischal Sharma <[email protected]>

mratsim · 2024-07-22T08:07:16Z

I'm curious how I can reproduce this bench, on my machine raw perf (i.e. not the EVM wrapper), constantine is faster than Gnark by 15%

Edit instead of reply confusion by garyschulte

it is also worth noting that we are not using a release version of gnark-crypto, but rather built from this sha

garyschulte · 2024-07-22T16:54:59Z

I'm curious how I can reproduce this bench, on my machine raw perf (i.e. not the EVM wrapper), constantine is faster than Gnark by 15%

it is a naive performance comparison, just running the unit test cases repeatedly 1000x for each input in a tight loop (only 100x for pairing test).

garyschulte · 2024-07-23T17:48:30Z

@NickSneo do you want or need help with the CI troubles? I think this PR is very promising, especially in light of the fact that we would like to have Constantine verkle bindings in besu-native.

IMO besu-native would benefit from having generalized bindings for both gnark-crypto and Constantine, rather than a collection of bespoke libraries. In that regard, I am keenly interested in getting this PR merged to get Constantine into the repo.

garyschulte · 2024-07-24T17:24:44Z

I'm curious how I can reproduce this bench, on my machine raw perf (i.e. not the EVM wrapper), constantine is faster than Gnark by 15%

it is also worth noting that we are not using a release version of gnark-crypto, but rather built from this sha

Sorry - somehow I edited your comment rather than replying.

NickSneo · 2024-07-24T18:56:15Z

@NickSneo do you want or need help with the CI troubles? I think this PR is very promising, especially in light of the fact that we would like to have Constantine verkle bindings in besu-native.

IMO besu-native would benefit from having generalized bindings for both gnark-crypto and Constantine, rather than a collection of bespoke libraries. In that regard, I am keenly interested in getting this PR merged to get Constantine into the repo.

@garyschulte I tried fixing pipeline with build.gradle approach but was not successful, looking into another approach to build like other projects and include this process in the root build.sh file

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo · 2024-07-29T10:27:49Z

@garyschulte Hey, with latest commit, everything is working fine with correct build.sh compiling nim shared lib and then in gradle.build copy it to correct place and tests working fine in my local machine. But Don't know why it is failing in pipeline.

Can you please check once?
Thanks

Signed-off-by: Nischal Sharma <[email protected]>

garyschulte · 2024-08-02T18:56:33Z

The problem is the way CI expects to build these libraries. It expects to run ./build.sh on four different architectures to build the corresponding shared library - once each for x86 and arm64 versions of both linux and mac. The result of each build step should be the upload of the shared library file(or files) as an artifact with the operating system and arch as part of the path inside the artifact. Then on the final assembly step it expects each subproject to take each of the native artifacts and build a jar with the java code and the native artifacts embedded within it.

In the final product, the process expects to be able to find the four native artifacts from each of the four build steps so it can embed them into the final multi-arch jar:

darwin-aarch64/libconstantine.dylib
darwin-x86-64/libconstantine.dylib
linux-x86-64/libconstantine.so
linux-aarch64/lib/libconstantine.so

Since CI is expecting to build across architectures, we should probably put a constantine build step into build.sh like:

build_constantine() {
  cat <<EOF
  ############################
  ####### build constantine #######
  ############################
EOF

  cd "$SCRIPTDIR"

  # delete old build dir, if exists
  rm -rf "$SCRIPTDIR/constantine/build" || true
  mkdir -p "$SCRIPTDIR/constantine/build/lib"

  if [[ "$OSTYPE" == "msys" ]]; then
    	LIBRARY_EXTENSION=dll
  elif [[ "$OSTYPE" == "linux-gnu"* ]]; then
    LIBRARY_EXTENSION=so
  elif [[ "$OSTYPE" == "darwin"* ]]; then
    LIBRARY_EXTENSION=dylib
  fi

  ./gradlew :constantine:clean :constantine:compileNativeLibrary

  mkdir -p "$SCRIPTDIR/constantine/build/${OSARCH}/lib"
  cp constantine/constantine/lib/libconstantine.* "$SCRIPTDIR/constantine/build/${OSARCH}/lib"
}

...

build_constantine

and make the requisite changes to the jar building process for the constantine subproject so that it pulls in the jars from the os-arch friendly artifact directories.

Lastly, we need to add upload and download steps for constantine artifacts in build.yml native build tasks. In each native build task, add an additional step like:

      - uses: actions/[email protected]
        with:
          name: constantine native build artifacts
          path: constantine/build/{PUT_OS_ARCH_STRING_HERE}/lib

and in the final-assembly task, pull all of the artifacts down by adding a step like:

      - name: Download constantine
        uses: actions/download-artifact@v3
        with:
          name: constantine native build artifacts
          path: constantine/build

NickSneo · 2024-08-06T15:30:38Z

The problem is the way CI expects to build these libraries. It expects to run ./build.sh on four different architectures to build the corresponding shared library - once each for x86 and arm64 versions of both linux and mac. The result of each build step should be the upload of the shared library file(or files) as an artifact with the operating system and arch as part of the path inside the artifact. Then on the final assembly step it expects each subproject to take each of the native artifacts and build a jar with the java code and the native artifacts embedded within it.

In the final product, the process expects to be able to find the four native artifacts from each of the four build steps so it can embed them into the final multi-arch jar:

darwin-aarch64/libconstantine.dylib darwin-x86-64/libconstantine.dylib linux-x86-64/libconstantine.so linux-aarch64/lib/libconstantine.so

Since CI is expecting to build across architectures, we should probably put a constantine build step into build.sh like:
build_constantine() {
  cat <<EOF
  ############################
  ####### build constantine #######
  ############################
EOF

  cd "$SCRIPTDIR"

  # delete old build dir, if exists
  rm -rf "$SCRIPTDIR/constantine/build" || true
  mkdir -p "$SCRIPTDIR/constantine/build/lib"

  if [[ "$OSTYPE" == "msys" ]]; then
    	LIBRARY_EXTENSION=dll
  elif [[ "$OSTYPE" == "linux-gnu"* ]]; then
    LIBRARY_EXTENSION=so
  elif [[ "$OSTYPE" == "darwin"* ]]; then
    LIBRARY_EXTENSION=dylib
  fi

  ./gradlew :constantine:clean :constantine:compileNativeLibrary

  mkdir -p "$SCRIPTDIR/constantine/build/${OSARCH}/lib"
  cp constantine/constantine/lib/libconstantine.* "$SCRIPTDIR/constantine/build/${OSARCH}/lib"
}

...

build_constantine
and make the requisite changes to the jar building process for the constantine subproject so that it pulls in the jars from the os-arch friendly artifact directories.

Lastly, we need to add upload and download steps for constantine artifacts in build.yml native build tasks. In each native build task, add an additional step like:
      - uses: actions/[email protected]
        with:
          name: constantine native build artifacts
          path: constantine/build/{PUT_OS_ARCH_STRING_HERE}/lib
and in the final-assembly task, pull all of the artifacts down by adding a step like:
      - name: Download constantine
        uses: actions/download-artifact@v3
        with:
          name: constantine native build artifacts
          path: constantine/build

Yes, I followed the exact same approach in my last commit - 7c9f645 but seems it is still failing. The upload and download steps are also working fine. But still the test is failing.

Seems the issue is from something else, I will investigate it further

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo · 2024-08-13T10:55:12Z

Hey @garyschulte , I was able to fix the pipeline issue.
I was using my work laptop which is Mac (m2) for testing and everything was working fine, but since the pipeline was failing in ubuntu x86_64, so I dual booted my PC with ubuntu and tested it in there. Seems there was an issue with LD_LIBRARY_PATH for which I added the required fix.

Now pipeline is passing. Please review and let me know if anything else is required from my side in this PR.

garyschulte · 2024-08-13T19:25:03Z

build.sh

+ # Skip if OSARCH is linux-gnu-aarch64
+ if [[ "$OSARCH" == "linux-gnu-aarch64" ]]; then
+ echo "Skipping build for OSARCH: ${OSARCH}"
+ return
+ fi


is this a CI-specific workaround? it looks like an arm64 linux host env would not be able to build constantine?

I skipped Linux arm64 build since nim installer was not compatible with it, and I didn't have an Linux arm environment to test it.
Will test and add in the follow on PR

garyschulte

This LGTM 👍

One non-blocking question about linux arm64 builds though.

garyschulte · 2024-08-13T20:03:22Z

Merging as-is, with an expectation that linux-arm64 will be added in a follow-on PR, as the CHOOSENIM install method does not work on linux arm64, and ubuntu does not have nim support until 23.10:

choosenim-init: Error: Sorry, your platform (linux_arm64) is not supported by choosenim.
choosenim-init: Error: You will need to install Nim using an alternative method.
choosenim-init: Error: See the following link for more info: https://nim-lang.org/install.html

constantine bindings

51496e8

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo requested review from garyschulte and matkt June 27, 2024 04:19

NickSneo marked this pull request as draft June 27, 2024 04:19

mratsim reviewed Jun 28, 2024

View reviewed changes

NickSneo added 2 commits July 12, 2024 13:08

C bindings and jni used

079cfd3

Signed-off-by: Nischal Sharma <[email protected]>

C bindings added and build.gradle changed

535504d

Signed-off-by: Nischal Sharma <[email protected]>

Merge branch 'main' into main

4d1c4e2

mratsim reviewed Jul 12, 2024

View reviewed changes

garyschulte reviewed Jul 15, 2024

View reviewed changes

constantine/build.gradle Outdated Show resolved Hide resolved

fixed errors and tests, modified build.gradle

c4c8eff

Signed-off-by: Nischal Sharma <[email protected]>

added test cases from Gnark lib

c84d5b5

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo added 4 commits July 18, 2024 07:28

added nim install in CI

d6423b9

Signed-off-by: Nischal Sharma <[email protected]>

choose nim to install

4292e57

Signed-off-by: Nischal Sharma <[email protected]>

updated install nim command

5c1570b

Signed-off-by: Nischal Sharma <[email protected]>

Merge branch 'main' into main

388eb98

NickSneo marked this pull request as ready for review July 18, 2024 02:37

NickSneo requested review from garyschulte and mratsim July 18, 2024 02:37

NickSneo changed the title ~~[WIP] Constantine bindings~~ Constantine bindings for EIP196 Jul 18, 2024

NickSneo added 2 commits July 18, 2024 08:12

fixed CI failing due to jfrog

9ecea5e

Signed-off-by: Nischal Sharma <[email protected]>

fix test task in CI

5cea62b

Signed-off-by: Nischal Sharma <[email protected]>

prev implementation is working

dac3084

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo added 8 commits July 29, 2024 11:49

just testing

235c91a

Signed-off-by: Nischal Sharma <[email protected]>

added constantine in build.sh

7c9f645

Signed-off-by: Nischal Sharma <[email protected]>

export PATH nimble

b96360c

Signed-off-by: Nischal Sharma <[email protected]>

fix outout dir

18b8050

Signed-off-by: Nischal Sharma <[email protected]>

added prepare for linux-arm64

620b308

Signed-off-by: Nischal Sharma <[email protected]>

skip for linux arm64

f824860

Signed-off-by: Nischal Sharma <[email protected]>

fix linkage and source not found

f35318f

Signed-off-by: Nischal Sharma <[email protected]>

fix lib copy directories

23a7190

Signed-off-by: Nischal Sharma <[email protected]>

fix for lib directory

03a6057

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo added 2 commits August 12, 2024 13:32

Merge branch 'main' into main

1423a90

fixed shared lib for linux

c5b504a

Signed-off-by: Nischal Sharma <[email protected]>

NickSneo requested a review from garyschulte August 13, 2024 11:14

Merge branch 'main' into main

98035f1

garyschulte reviewed Aug 13, 2024

View reviewed changes

garyschulte approved these changes Aug 13, 2024

View reviewed changes

garyschulte merged commit 462238e into hyperledger:main Aug 13, 2024
11 checks passed

This was referenced Aug 13, 2024

Add linux arm64 support in Constantine build #198

Closed

release version for 0.9.4 #199

Closed

release version for 0.9.4 #200

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Constantine bindings for EIP196 #184

Constantine bindings for EIP196 #184

NickSneo commented Jun 27, 2024 •

edited

Loading

garyschulte commented Jun 27, 2024

mratsim left a comment

mratsim Jun 28, 2024

NickSneo Jul 2, 2024

NickSneo commented Jul 12, 2024

mratsim Jul 12, 2024

garyschulte Jul 15, 2024 •

edited

Loading

mratsim Jul 15, 2024

garyschulte left a comment •

edited

Loading

garyschulte Jul 15, 2024

garyschulte Jul 15, 2024

garyschulte left a comment •

edited

Loading

NickSneo commented Jul 16, 2024

NickSneo commented Jul 17, 2024

NickSneo commented Jul 17, 2024

mratsim commented Jul 22, 2024 •

edited

Loading

garyschulte commented Jul 22, 2024

garyschulte commented Jul 23, 2024

garyschulte commented Jul 24, 2024

NickSneo commented Jul 24, 2024 •

edited

Loading

NickSneo commented Jul 29, 2024 •

edited

Loading

garyschulte commented Aug 2, 2024 •

edited

Loading

NickSneo commented Aug 6, 2024

NickSneo commented Aug 13, 2024

garyschulte Aug 13, 2024

NickSneo Aug 13, 2024

garyschulte left a comment

garyschulte commented Aug 13, 2024 •

edited

Loading

Constantine bindings for EIP196 #184

Constantine bindings for EIP196 #184

Conversation

NickSneo commented Jun 27, 2024 • edited Loading

garyschulte commented Jun 27, 2024

mratsim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NickSneo commented Jul 12, 2024

Choose a reason for hiding this comment

garyschulte Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garyschulte left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garyschulte left a comment • edited Loading

Choose a reason for hiding this comment

NickSneo commented Jul 16, 2024

NickSneo commented Jul 17, 2024

NickSneo commented Jul 17, 2024

mratsim commented Jul 22, 2024 • edited Loading

garyschulte commented Jul 22, 2024

garyschulte commented Jul 23, 2024

garyschulte commented Jul 24, 2024

NickSneo commented Jul 24, 2024 • edited Loading

NickSneo commented Jul 29, 2024 • edited Loading

garyschulte commented Aug 2, 2024 • edited Loading

NickSneo commented Aug 6, 2024

NickSneo commented Aug 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garyschulte left a comment

Choose a reason for hiding this comment

garyschulte commented Aug 13, 2024 • edited Loading

NickSneo commented Jun 27, 2024 •

edited

Loading

garyschulte Jul 15, 2024 •

edited

Loading

garyschulte left a comment •

edited

Loading

garyschulte left a comment •

edited

Loading

mratsim commented Jul 22, 2024 •

edited

Loading

NickSneo commented Jul 24, 2024 •

edited

Loading

NickSneo commented Jul 29, 2024 •

edited

Loading

garyschulte commented Aug 2, 2024 •

edited

Loading

garyschulte commented Aug 13, 2024 •

edited

Loading