Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API method #1677

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Add API method #1677

merged 10 commits into from
Sep 6, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Aug 22, 2024

Description

  • Add priv_traceTransactions API method to docs

Issue(s) fixed

Fixes #1669

Preview

Signed-off-by: Joan E <[email protected]>
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 7:53pm

@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review August 22, 2024 19:00
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner August 22, 2024 19:00
@macfarla
Copy link
Contributor

macfarla commented Aug 26, 2024

you could add more details for the params and return object. should be the same as debug_traceTransaction trace_transaction

Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
Copy link
Contributor Author

Thanks @macfarla. I updated the spec Could you please review again?

@macfarla
Copy link
Contributor

macfarla commented Aug 27, 2024

looking good - maybe add a link back to debug_traceTransaction trace_transaction - this is the same, just for private tx

Signed-off-by: Joan E <[email protected]>
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
Copy link
Contributor Author

joaniefromtheblock commented Aug 28, 2024

@NickSneo could you PTAL and review? Really appreciate it

Signed-off-by: Joan E <[email protected]>
@NickSneo
Copy link
Contributor

@NickSneo could you PTAL and review? Really appreciate it

Sure, checking

Signed-off-by: Joan E <[email protected]>
Signed-off-by: Joan E <[email protected]>
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes

docs/private-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/private-networks/reference/api/index.md Show resolved Hide resolved
Signed-off-by: Joan E <[email protected]>
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaniefromtheblock joaniefromtheblock merged commit 41f38be into main Sep 6, 2024
11 checks passed
@joaniefromtheblock joaniefromtheblock deleted the priv-trace-transactions branch September 6, 2024 19:23
joaniefromtheblock added a commit that referenced this pull request Sep 19, 2024
* Add API method

Signed-off-by: Joan E <[email protected]>

* Update

Signed-off-by: Joan E <[email protected]>

* add link

Signed-off-by: Joan E <[email protected]>

* update links

Signed-off-by: Joan E <[email protected]>

* add cli

Signed-off-by: Joan E <[email protected]>

* reorder

Signed-off-by: Joan E <[email protected]>

* remove options

Signed-off-by: Joan E <[email protected]>

* Update examples

Signed-off-by: Joan E <[email protected]>

---------

Signed-off-by: Joan E <[email protected]>
Co-authored-by: m4sterbunny <[email protected]>
Signed-off-by: Joan E <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing private transactions feature
5 participants