Make PeerDid generic over numalgo #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirgee
force-pushed
the
refactor/did-peer
branch
3 times, most recently
from
d75d554
to
8d1e713
Compare
mirgee
force-pushed
the
refactor/did-peer
branch
5 times, most recently
from
b357d56
to
6813c70
Compare
mirgee
force-pushed
the
refactor/did-peer
branch
from
6813c70
to
5185c48
Compare
Codecov Report
@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 49.90% 46.25% -3.66%
==========================================
Files 432 432
Lines 35058 35058
Branches 7617 7611 -6
==========================================
- Hits 17497 16215 -1282
- Misses 12284 13900 +1616
+ Partials 5277 4943 -334
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Miroslav Kovar <[email protected]>
mirgee
force-pushed
the
refactor/did-peer
branch
from
5185c48
to
74aa091
Compare
Patrik-Stas
previously approved these changes
Jun 29, 2023
bobozaur
reviewed
Jun 30, 2023
Signed-off-by: Miroslav Kovar <[email protected]>
bobozaur
approved these changes
Jul 3, 2023
Patrik-Stas
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the peer did submethod (numalgo) part of the
PeerDidtype, allowing for statically ensuringGenericPeerDidenum was added to cover situations when there is no concrete numalgo expected.