feat: load wallet config from environment variables #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naian <[email protected]>
nain-F49FF806
force-pushed
the
feat/mediator/wallet-config
branch
from
f8d81c8
to
2ba3938
Compare
xprazak2
approved these changes
Apr 16, 2024
|
@xprazak2 Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give full control over mediator.
Note: We could later support a dedicated config file format such as yaml/toml. Or command line arguments to pass config parameters.
But simply with env variables, we still have sufficient control.
One can pass the environment variables on the command line or declare them in a
.envfile.The
.envfile may be in the same directory as where mediator is executed, or a parent directory. [dotenvy]