Skip to content

Commit

Permalink
Revert "release 4.12.3"
Browse files Browse the repository at this point in the history
This reverts commit b5bbbd3.
  • Loading branch information
gtebrean committed Dec 24, 2024
1 parent b5bbbd3 commit 6bd0cca
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<groupId>org.web3j</groupId>
<artifactId>web3j-maven-plugin</artifactId>
<packaging>maven-plugin</packaging>
<version>4.12.3-SNAPSHOT</version>
<version>4.12.3</version>

<name>web3j Maven Mojo</name>
<description>Mojo's web3j Maven plugin is used to create java classes based on the solidity
Expand Down Expand Up @@ -77,9 +77,9 @@
</dependency>

<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.10.0</version>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.1</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/web3j/mavenplugin/IssueITest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
import java.util.Set;
import java.util.stream.Collectors;

import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.junit.internal.matchers.StringContains.containsString;

public class IssueITest {

Expand Down Expand Up @@ -164,7 +164,7 @@ public void issue63() throws Exception {
assertThat("Interface and java classes are generated", files.size(), is(1));
File file = files.get(0);
assertThat(file.getName(), is("Greeter.java"));
String content = FileUtils.readFileToString(file);;
String content = FileUtils.readFileToString(file);
assertThat(content, containsString("greet()"));
assertThat(content, containsString("kill()"));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import java.util.Collections;
import java.util.Set;

import static org.hamcrest.CoreMatchers.containsString;
import static org.junit.Assert.*;
import static org.junit.Assert.assertThat;

Expand Down Expand Up @@ -48,7 +49,7 @@ public void invalidContractVersion() {
solidityCompiler.compileSrc("src/test/resources/", source, new String[0], SolidityCompiler.Options.ABI, SolidityCompiler.Options.BIN);
fail("Should throw a version mismatch exception.");
} catch (Exception v) {
assertTrue(v.getMessage().contains("No compatible solc release could be found for the file"));
assertThat(v.getMessage(), containsString("No compatible solc release could be found for the file"));
}
}

Expand All @@ -60,7 +61,7 @@ public void pragmaVersionTooHigh() {
solidityCompiler.compileSrc("src/test/resources/", source, new String[0], SolidityCompiler.Options.ABI, SolidityCompiler.Options.BIN);
fail("Should throw a version mismatch exception.");
} catch (Exception v) {
assertTrue(v.getMessage().contains("No compatible solc release could be found for the file"));
assertThat(v.getMessage(), containsString("No compatible solc release could be found for the file"));
}
}

Expand Down

0 comments on commit 6bd0cca

Please sign in to comment.