Add Sidebar history Section #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaptr
reviewed
Aug 21, 2024
Sauradip07
force-pushed
the
SidebarHistroy1
branch
from
cf2d7c6 to
3b97558
Compare
Signed-off-by: Sauradip Ghosh <[email protected]>
Signed-off-by: Sauradip Ghosh <[email protected]>
Signed-off-by: Sauradip Ghosh <[email protected]>
Signed-off-by: Sauradip Ghosh <[email protected]>
Sauradip07
force-pushed
the
SidebarHistroy1
branch
from
90b84b5 to
b1a160c
Compare
Signed-off-by: Sauradip Ghosh <[email protected]>
Signed-off-by: Sauradip Ghosh <[email protected]>
swaptr
reviewed
Aug 29, 2024
| </Button> | ||
| </DropdownMenuTrigger> | ||
| <DropdownMenuContent className="w-56"> | ||
| <DropdownMenuSeparator /> |
| > | ||
| <Pin className="mr-2" /> Pin | ||
| </DropdownMenuCheckboxItem> | ||
| <button className="p-[7px] flex flex-rowtext-left w-full hover:bg-hover-blue border-none hover:border-none "> |
There was a problem hiding this comment.
I think these can be Link instead.
| @@ -24,6 +24,7 @@ const config = { | |||
| extend: { | |||
| colors: { | |||
| border: 'hsl(var(--border))', | |||
| 'hover-blue': '#f1f5f9', | |||
There was a problem hiding this comment.
Remove this, just use a lighter shade of whatever is available.
Comment on lines
+38
to
+46
| useEffect(() => { | ||
| setButtonClass( | ||
| `rounded-full flex-shrink-0 transition-opacity duration-200 ${ | ||
| message.content.trim() | ||
| ? 'opacity-100' | ||
| : 'opacity-50' | ||
| }` | ||
| ); | ||
| }, [message.content]); |
There was a problem hiding this comment.
You could instead use a disabled variable. Makes it easier when you extend it with global state.
| @@ -111,9 +124,10 @@ const ChatBottomBar = ({ onSend }: Props) => { | |||
| <Button | |||
| size="icon" | |||
| variant="default" | |||
| className="rounded-full flex-shrink-0" | |||
| className={buttonClass} | |||
There was a problem hiding this comment.
And the styling logic moves here.
There was a problem hiding this comment.
Note: You can use cn() from utils.
| </span> | ||
| </button> | ||
|
|
||
| <button className="p-[7px] flex flex-rowtext-left w-full hover:bg-hover-blue border-none hover:border-none "> |
Signed-off-by: Sauradip Ghosh <[email protected]>
Signed-off-by: Sauradip Ghosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Truncated Display for History Titles
Added a feature to truncate titles in the Sidebar History component.
Introduced a truncate Title helper function to limit the title length to 17 characters and append an ellipsis if necessary.
Added a historyData.ts file to provide mock data for testing and development.
Dynamic Opacity for Send Button :-
Ensure that the send button in the
ChatBottomBarcomponent appears with50%opacity when the input field is empty.Verify that the opacity changes to
100%when the input field is not empty.Confirm that the button is disabled when no text is entered and enabled when text is present.
Backend Integration:
Screencast.from.2024-08-12.23-34-52.mp4