Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add warp config writer logic #511

Merged
merged 17 commits into from
Jan 22, 2025
Merged

feat: Add warp config writer logic #511

merged 17 commits into from
Jan 22, 2025

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Jan 21, 2025

Description

Add warp config writer Registry logic

Generated by hyperlane-xyz/hyperlane-monorepo#5235

Backward compatibility

Yes

Fixes hyperlane-xyz/hyperlane-monorepo#5260

@ltyu ltyu requested review from nambrot and jmrossy January 21, 2025 21:37
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: e297125

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR not also contain the logic to fetch the warp deploy config so that we can ensure that the config is in sync with the monorepo getters?

src/registry/FileSystemRegistry.ts Outdated Show resolved Hide resolved
configs/warp_routes/USDT/ethereum-viction.yaml Outdated Show resolved Hide resolved
@paulbalaji
Copy link
Contributor

should we first make the src-only changes in a PR, publish, update monorepo, and then add the exported configs in a separate PR?

(or are we ok with that monorepo PR failing for now)

@jmrossy
Copy link
Collaborator

jmrossy commented Jan 22, 2025

+1 to separate logic from config changes if you don't mind

@ltyu ltyu changed the title feat: Add warp configs and warp config writer feat: Add warp warp config writer Jan 22, 2025
@ltyu ltyu changed the title feat: Add warp warp config writer feat: Add warp warp config writer logic Jan 22, 2025
@ltyu ltyu changed the title feat: Add warp warp config writer logic feat: Add warp config writer logic Jan 22, 2025
### Description
Adds existing warp route configs generated by infra Getters

### Backward compatibility
Yes

### Testing

<!--
Have any new metadata configs and deployment addresses been used with
any Hyperlane tooling, such as the CLI?
-->
@ltyu ltyu enabled auto-merge January 22, 2025 23:33
@ltyu ltyu added this pull request to the merge queue Jan 22, 2025
@ltyu ltyu removed this pull request from the merge queue due to a manual request Jan 22, 2025
@ltyu ltyu enabled auto-merge January 22, 2025 23:36
@ltyu ltyu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit d3a6517 Jan 22, 2025
6 checks passed
@ltyu ltyu deleted the ltyu/warp-speed-exportConfigs branch January 22, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warp Deploy Config writing via IRegistry
4 participants