feat: ZKSync provider types #5207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hyperlane-monorepo-zksync into txfusion/sending-messages
…/core from major to minor
…ess for ZKSync support
nambrot
reviewed
Jan 23, 2025
| type: ProviderType.ZkSync; | ||
| transaction: zkSyncTypes.TransactionRequest; | ||
| } | ||
|
|
There was a problem hiding this comment.
Doesn't it have to ba added to the enum below?
There was a problem hiding this comment.
How did this not cause an issue in a later PR?
There was a problem hiding this comment.
ethers/zksync-ethers provider are similar enough in where we use them that it would still be fine with the original ethers provider type / interface
would open up something breaking in the future should we do something that is in the zk-ethers but not in regular ethers
paulbalaji
reviewed
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5207 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
paulbalaji
approved these changes
Jan 23, 2025
…zksync-sdk-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces specific ZKSync Provider types for SDK.
PR to feat/core-zksync
Drive-by changes
Related issues
None
Backward compatibility
Yes
Testing
Build passing