Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix signer init strategy #4987

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix(cli): fix signer init strategy #4987

merged 3 commits into from
Dec 12, 2024

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Dec 11, 2024

Description

Probably fixes an issue due to a recent pr merge that changes how signers are initialized based on the command to be executed

Drive-by changes

  • Updates the key info message log level from info to debug to avoid the following
    image

Related issues

Backward compatibility

  • Yes

Testing

  • Manual

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 93d5378

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (4d342db) to head (93d5378).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4987   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@xeno097 xeno097 changed the title fix(cli): fix singer init strategy fix(cli): fix signer init strategy Dec 11, 2024
@xeno097 xeno097 requested a review from paulbalaji December 12, 2024 14:16
@xeno097 xeno097 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit c2ca849 Dec 12, 2024
38 of 39 checks passed
@xeno097 xeno097 deleted the fix/signer-strategy branch December 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants