-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ica submission strategy support in the cli #4980
Open
xeno097
wants to merge
32
commits into
main
Choose a base branch
from
xeno/ica-submission-strategy-support-in-the-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+676
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to xeno/update-ism-derivation-for-ica-support
…ta building from on chain data to enable self relaying of ICA messages
…to xeno/update-ism-derivation-for-ica-support
…dule delta if the ism is an ica ism
…to xeno/ica-submission-strategy-support-in-the-cli
…if the config specifies so
…one is supplied in the strategy file when using ICAs
…s if none is supplied in the config
…to xeno/ica-submission-strategy-support-in-the-cli
…to xeno/ica-submission-strategy-support-in-the-cli
…to xeno/ica-submission-strategy-support-in-the-cli
🦋 Changeset detectedLatest commit: ead2c66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
… to send them when provided with the appropriate strategy config
…to xeno/ica-submission-strategy-support-in-the-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the implementation for sending ICA transactions using the CLI when running
warp apply
and adds arelay
flag so that ICA transactions can be self-relayed when using the JSON RPC strategy as the internal submission strategy.Drive-by changes
Related issues
Backward compatibility
Testing