Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ica submission strategy support in the cli #4980

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Dec 10, 2024

Description

This PR updates the implementation for sending ICA transactions using the CLI when running warp apply and adds a relay flag so that ICA transactions can be self-relayed when using the JSON RPC strategy as the internal submission strategy.

Drive-by changes

  • Removes the transformer logic from the submitter getter

Related issues

Backward compatibility

  • No, the way to define how to send ICA transactions has changed compared to previous CLI versions

Testing

  • Manual
  • E2E

…to xeno/update-ism-derivation-for-ica-support
…ta building from on chain data to enable self relaying of ICA messages
…to xeno/update-ism-derivation-for-ica-support
…to xeno/ica-submission-strategy-support-in-the-cli
…one is supplied in the strategy file when using ICAs
…to xeno/ica-submission-strategy-support-in-the-cli
…to xeno/ica-submission-strategy-support-in-the-cli
…to xeno/ica-submission-strategy-support-in-the-cli
@xeno097 xeno097 requested a review from paulbalaji as a code owner December 10, 2024 14:42
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: ead2c66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Major
@hyperlane-xyz/sdk Major
@hyperlane-xyz/helloworld Major
@hyperlane-xyz/infra Major
@hyperlane-xyz/widgets Major
@hyperlane-xyz/ccip-server Major
@hyperlane-xyz/github-proxy Major
@hyperlane-xyz/utils Major
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xeno097 xeno097 marked this pull request as draft December 10, 2024 14:42
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (5b70527) to head (ead2c66).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4980   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@xeno097 xeno097 marked this pull request as ready for review December 10, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant