Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate ZKSync Wallet for ChainTechnicalStack-Specific Transaction Signing #4914

Open
wants to merge 77 commits into
base: main
Choose a base branch
from

Conversation

mshojaei-txfusion
Copy link
Contributor

Description

This PR integrates the zksync-ethers wallet implementation for the ZKSync signer strategy. Key changes include:

  • Added zksync-ethers dependency (v5.10.0)
  • Updated ZKSyncSignerStrategy to use ZKSyncWallet instead of standard ethers Wallet
  • Removed outdated TODO comment about ZKSync signer implementation

Drive-by changes

None

Related issues

N/A

Backward compatibility

Yes

Testing

Manual testing

mortezashojaei and others added 30 commits October 16, 2024 15:07
…ocolSigner implementation for flexible cross-chain signer configuration and management
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (6e496b0) to head (b58434e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4914   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@mergify mergify bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants