feat: posting ECDSARegistry signature to s3 bucket for validators #3674
Conversation
|
| #[derive(Clone, Debug, Default)] | ||
| pub struct StakingConf { | ||
| /// Address of the HyperlaneServiceManager contract | ||
| pub service_managers: HashMap<u32, H160>, |
There was a problem hiding this comment.
will there be stuff in here other than the service_managers?
There was a problem hiding this comment.
Yes, I imagine we'll have more config once we have native staking which will also have some form of registration announcement in a json form.
| @@ -40,6 +41,8 @@ pub struct ValidatorSettings { | |||
| pub reorg_period: u64, | |||
| /// How frequently to check for new checkpoints | |||
| pub interval: Duration, | |||
|
|
|||
| pub staking_config: StakingConf, | |||
There was a problem hiding this comment.
Do you expect to ever have this be set via settings?
if we won't ever have a different config other than the default_staking_config, imo you could just not even have this in ValidatorSettings, and just create it in impl BaseAgent for Validator {
There was a problem hiding this comment.
given the above comment, I was anticipating we may need to set it via settings as you mentioned
| @@ -122,6 +124,7 @@ impl BaseAgent for Validator { | |||
| agent_metrics, | |||
| chain_metrics, | |||
| core_metrics: metrics, | |||
| staking_config: settings.staking_config, | |||
There was a problem hiding this comment.
imo instead of storing a config in the Validator that you can then lookup
let service_manager = self
.staking_config
.service_managers
.get(&avs_domain)
it'd be nicer to just do that lookup in here when building the Validator once, and then store the service_manager as the config in the Validator
aroralanuk
requested review from
daniel-savu,
yorhodes and
nbayindirli
as code owners
Description
Drive-by changes
Related issues
Backward compatibility
Testing