Retry fetching messages when indexing on v2 #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2 #3613 +/- ##
=======================================
Coverage 71.02% 71.02%
=======================================
Files 95 95
Lines 1446 1446
Branches 189 189
=======================================
Hits 1027 1027
Misses 410 410
Partials 9 9
|
daniel-savu
approved these changes
Apr 16, 2024
tkporter
changed the title
daniel-savu
pushed a commit
that referenced
this pull request
Jun 5, 2024
### Description - Retries infinitely for messages. This avoids skipping a message range and preventing the message processor loop from proceeding - Intentionally does not retry for IGP payments - this is required bc Solana IGP payment indexing is broken atm, so we can expect errors there. In practice this has not been an issue, only message indexing ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing