-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGP Oracle Updates #3524
IGP Oracle Updates #3524
Conversation
|
@@ -95,7 +96,7 @@ export class HyperlaneIgpDeployer extends HyperlaneDeployer< | |||
return gasOracle; | |||
} | |||
|
|||
this.logger.debug(`Configuring gas oracle from ${chain}...`); | |||
console.log(`Configuring gas oracle from ${chain}...`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why switch back from logger
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm– see this likely won't be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this should get reverted indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from minor comment on logger
"base": "0.0010003", | ||
"scroll": "0.46", | ||
"polygonzkevm": "3.95", | ||
"bsc": "7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you update just gasPrices or also token exchange rates?
also are these values handcrafted or were they generated by the tooling?
Do you see yourself merging this into main or that https://github.com/hyperlane-xyz/issues/issues/1178 will take this over / supersede this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not adjust the token exchange rates
Description
Had a bit of back and forth on updating the oracles. Executed the config for EVM <> EVM routes. Had to effectively disable StorageGasOracle setting because of https://github.com/hyperlane-xyz/issues/issues/1178. So this probably shouldn't be merged as is, but wanted to open it up. Should be considred up-to-date vs. #3502
Drive-by changes
Related issues
Backward compatibility
Testing