Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGP Oracle Updates #3524

Closed
wants to merge 7 commits into from
Closed

IGP Oracle Updates #3524

wants to merge 7 commits into from

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented Apr 1, 2024

Description

Had a bit of back and forth on updating the oracles. Executed the config for EVM <> EVM routes. Had to effectively disable StorageGasOracle setting because of https://github.com/hyperlane-xyz/issues/issues/1178. So this probably shouldn't be merged as is, but wanted to open it up. Should be considred up-to-date vs. #3502

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Apr 1, 2024

⚠️ No Changeset found

Latest commit: 4038d9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -95,7 +96,7 @@ export class HyperlaneIgpDeployer extends HyperlaneDeployer<
return gasOracle;
}

this.logger.debug(`Configuring gas oracle from ${chain}...`);
console.log(`Configuring gas oracle from ${chain}...`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why switch back from logger?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm– see this likely won't be merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, should be reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should get reverted indeed

Copy link
Contributor

@nbayindirli nbayindirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from minor comment on logger

"base": "0.0010003",
"scroll": "0.46",
"polygonzkevm": "3.95",
"bsc": "7",
Copy link
Collaborator

@tkporter tkporter Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you update just gasPrices or also token exchange rates?

also are these values handcrafted or were they generated by the tooling?

Do you see yourself merging this into main or that https://github.com/hyperlane-xyz/issues/issues/1178 will take this over / supersede this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not adjust the token exchange rates

@nambrot nambrot closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants