Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move desired balances into KeyFunderConfig + bump thresholds #3284

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

paulbalaji
Copy link
Contributor

resolves #2385

  • moves desired balances into KeyFunderConfig
  • update balances across the board

Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: 75dff6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji paulbalaji marked this pull request as ready for review February 19, 2024 12:52
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
@paulbalaji paulbalaji enabled auto-merge (squash) February 19, 2024 15:49
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #3284 (75dff6b) into main (45acb73) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3284   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          99       99           
  Lines        1014     1014           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        284      284           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@paulbalaji paulbalaji merged commit d8507d3 into main Feb 19, 2024
28 checks passed
@paulbalaji paulbalaji deleted the feat/keyfunder-balance-update branch February 19, 2024 16:09
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2024
…ine args (#4074)

hit successor to
#3284
resolves #4049

- igp claim thresholds are moved to command line args instead, like
desired balances
	- making it easier to tweak IGP claim thresholds
- default claim threshold is 20% of desired balance for that chain
- roughly follows what I've seen with the other balance vs igp claim
thresholds
- adding thresholds for all chains we've configured a desired relayer
balance for
- drive-by fixing keyfunder logging to include the relevant metadata

testing:
- ran locally and successfully performed igp claims on
[blast](https://blastscan.io/tx/0x314d83d16e0406f77731befc7e8387dc946af01f7dc2200a426ff9748ad76d27),
[linea](https://lineascan.build/tx/0xa5f4731ebcff073dacc6c15326196002bafd9578059688fd2f29db1a2742cb14),
[viction](https://www.vicscan.xyz/tx/0x39921d3018a7b019518aa7a55a45ff29cce379bb9aabf0910c14423bd88689d5)
& more

---------

Signed-off-by: pbio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants