Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP Gateway Server #3273

Merged
merged 13 commits into from
Mar 5, 2024
Merged

CCIP Gateway Server #3273

merged 13 commits into from
Mar 5, 2024

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Feb 15, 2024

Description

Gateway Server and Proof Services to create proofs to be consumed by LightClient ISM. See README for more details

Drive-by changes

Related issues

Used in #3149

Backward compatibility

Yes

Testing

Manual/Unit Tests

Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: 6ac638f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@avious00
Copy link
Contributor

@yorhodes i believe you started looking at this but friendly ping to review for le

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly makes sense
lets chat offline

typescript/ccip-server/README.md Show resolved Hide resolved
typescript/ccip-server/src/services/ProofsService.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/abis/TelepathyCcipReadIsmAbi.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/config.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/LightClientService.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/ProofsService.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/RPCService.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/common/Requestor.ts Outdated Show resolved Hide resolved
typescript/ccip-server/tests/mocks/RPCServiceMock.ts Outdated Show resolved Hide resolved
…eration logic from LightClientService into ProofService, Remove HandlerDescriptionMock
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good but found a few problem, particularly with the package.json

typescript/ccip-server/package.json Outdated Show resolved Hide resolved
typescript/ccip-server/package.json Outdated Show resolved Hide resolved
typescript/ccip-server/package.json Outdated Show resolved Hide resolved
typescript/ccip-server/package.json Show resolved Hide resolved
typescript/ccip-server/src/services/LightClientService.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/LightClientService.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/common/Requestor.ts Outdated Show resolved Hide resolved
typescript/ccip-server/src/services/common/Requestor.ts Outdated Show resolved Hide resolved
typescript/ccip-server/README.md Show resolved Hide resolved
@jmrossy
Copy link
Contributor

jmrossy commented Feb 29, 2024

Please get CI green and then I'll coordinate with Yorke about merging this

@ltyu
Copy link
Contributor Author

ltyu commented Mar 4, 2024

Please get CI green and then I'll coordinate with Yorke about merging this

Got it. I have 1 that's failing and I'm confused on why one of the tests unrelated to my PR is failing. Am I missing something?

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #3273 (6ac638f) into main (332826c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3273   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          99       99           
  Lines        1014     1014           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        284      284           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

@aroralanuk aroralanuk enabled auto-merge (squash) March 5, 2024 16:36
@aroralanuk aroralanuk merged commit 16c0fb1 into hyperlane-xyz:main Mar 5, 2024
32 of 33 checks passed
@ltyu ltyu deleted the ccip-server branch March 5, 2024 18:29
@ltyu ltyu restored the ccip-server branch March 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants