-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP Gateway Server #3273
CCIP Gateway Server #3273
Conversation
|
@yorhodes i believe you started looking at this but friendly ping to review for le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly makes sense
lets chat offline
typescript/ccip-server/src/services/common/HandlerDescriptionEnumerated.ts
Outdated
Show resolved
Hide resolved
…eration logic from LightClientService into ProofService, Remove HandlerDescriptionMock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good but found a few problem, particularly with the package.json
Please get CI green and then I'll coordinate with Yorke about merging this |
Got it. I have 1 that's failing and I'm confused on why one of the tests unrelated to my PR is failing. Am I missing something? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3273 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 99 99
Lines 1014 1014
Branches 106 106
=======================================
Hits 686 686
Misses 284 284
Partials 44 44
|
Description
Gateway Server and Proof Services to create proofs to be consumed by LightClient ISM. See README for more details
Drive-by changes
Related issues
Used in #3149
Backward compatibility
Yes
Testing
Manual/Unit Tests