Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy eclipse testnet #3172

Merged
merged 9 commits into from
Jan 23, 2024
Merged

Deploy eclipse testnet #3172

merged 9 commits into from
Jan 23, 2024

Conversation

daniel-savu
Copy link
Contributor

Description

Drive-by changes

Related issues

Backward compatibility

Testing

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5db6b0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

Merging #3172 (5db6b0c) into main (5b4af6b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3172   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files         101      101           
  Lines        1021     1021           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        291      291           
  Partials       44       44
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 54.62% <ø> (ø)
middlewares 81.46% <ø> (ø)

tkporter
tkporter approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting that this also includes the tooling changes from #2778 that I wrote a while back, and I didn't really do a review of them here. Imo this is probably fine as the tooling isn't likely to be on a critical path for much work

.../environments/testnet4/multisig-ism-message-id/eclipsetestnet/hyperlane/multisig-config.json Show resolved Hide resolved
rust/sealevel/programs/hyperlane-sealevel-igp/src/instruction.rs Outdated Show resolved Hide resolved
rust/sealevel/programs/hyperlane-sealevel-igp/src/instruction.rs Outdated Show resolved Hide resolved
@daniel-savu daniel-savu enabled auto-merge (squash) January 23, 2024 11:01
@daniel-savu daniel-savu merged commit 528a190 into main Jan 23, 2024
27 of 28 checks passed
@daniel-savu daniel-savu deleted the dan/deploy-eclipse-testnet branch January 23, 2024 11:24
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
@daniel-savu @tkporter @ltyu
Deploy eclipse testnet (hyperlane-xyz#3172)
30bb62b 
### Description

<!--
What's included in this PR?
-->

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->

---------

Co-authored-by: Trevor Porter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkporter tkporter tkporter approved these changes

@nambrot nambrot Awaiting requested review from nambrot

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-savu @tkporter