Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Telepathy ism #3149

Closed
wants to merge 84 commits into from
Closed

feat: Telepathy ism #3149

wants to merge 84 commits into from

Conversation

ltyu
Copy link
Contributor

@ltyu ltyu commented Jan 13, 2024 •
edited
Loading

Description

  • Adds a CCIP Hook to write to a dispatched mapping to allow storage proofs
  • Adds CCIP read ism/LightClient that reads the proven state root from Succinct's LightClient
  • Gateway used to make requests to Succinct prover

Drive-by changes

No

Related issues

Backward compatibility

Yes

Testing

Manual/Unit Tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2bd1817

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@avious00
Copy link
Contributor

excited for this!

@ltyu ltyu marked this pull request as ready for review January 18, 2024 14:48
@avious00
Copy link
Contributor

hey @ltyu saw you requested my review. is this ready for yorke to take a look?

aroralanuk pushed a commit that referenced this pull request Mar 5, 2024
@ltyu
CCIP Gateway Server (#3273)
16c0fb1 
### Description
Gateway Server and Proof Services to create proofs to be consumed by
LightClient ISM. See README for more details

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues
Used in #3149 

### Backward compatibility
Yes

### Testing
Manual/Unit Tests
@ltyu ltyu removed the request for review from Skunkchain March 6, 2024 18:21
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Merging #3149 (56f7d8d) into main (0bdabb8) will decrease coverage by 1.88%.
Report is 13 commits behind head on main.
The diff coverage is 6.25%.

❗ Current head 56f7d8d differs from pull request most recent head ff1ef05. Consider uploading reports for the commit ff1ef05 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
- Coverage   67.65%   65.77%   -1.88%     
==========================================
  Files          99      102       +3     
  Lines        1014     1046      +32     
  Branches      106      110       +4     
==========================================
+ Hits          686      688       +2     
- Misses        284      314      +30     
  Partials       44       44
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.75% <66.66%> (-0.05%) ⬇️
isms 57.59% <0.00%> (-8.35%) ⬇️
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

taeguk
taeguk reviewed Apr 11, 2024
View reviewed changes
solidity/contracts/isms/ccip-read/telepathy/TelepathyCcipReadIsm.sol
Mailbox _sourceMailbox,
Mailbox _destinationMailbox,
TelepathyCcipReadHook _telepathyCcipReadHook,
address _lightClient,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@param for this param is missing.

@ltyu ltyu requested a review from nbayindirli as a code owner July 20, 2024 20:01
@ltyu ltyu changed the title Telepathy ism feat: Telepathy ism Jul 21, 2024
@ltyu
Copy link
Contributor Author

ltyu commented Nov 23, 2024

closed for #4334

@ltyu ltyu closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeguk taeguk taeguk left review comments

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

@nambrot nambrot Awaiting requested review from nambrot

@avious00 avious00 Awaiting requested review from avious00

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

@nbayindirli nbayindirli Awaiting requested review from nbayindirli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ltyu @avious00 @nambrot @taeguk @yorhodes @jmrossy @tkporter @daniel-savu