GRPC refactor #2905
Merged
GRPC refactor #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etwork/abacus-monorepo into trevor/grpc-refactor-1
daniel-savu
approved these changes
Nov 9, 2023
Comment on lines
+48
to
+51
| /// Note that in Tendermint, validators come to consensus on a block | ||
| /// before they execute the transactions in that block. This means that | ||
| /// we may not be able to make state queries against this block until | ||
| /// the next one is committed! |
| // As this function is only used for estimating gas or sending transactions, | ||
| // we can reasonably expect to have a signer. | ||
| let signer = self.get_signer()?; | ||
| let account_info = self.account_query(signer.address.clone()).await?; |
There was a problem hiding this comment.
I assume we're not precomputing this in the constructor because we want to keep it synchronous? Don't think it's worth caching otherwise but was just wondering
There was a problem hiding this comment.
I think "account number" can be cached but fetching the sequence number (i.e. the nonce to use for the next tx) should still be done. Just in case other txs from that key happen to have been made elsewhere
|
|
||
| let tx_body = tx::Body::new( | ||
| msgs, | ||
| "", |
There was a problem hiding this comment.
cleaner to use Default::default() here
There was a problem hiding this comment.
the expected value is impl Into<String> so I'll just do String::default()
| let raw_tx = TxRaw { | ||
| body_bytes: sign_doc.body_bytes, | ||
| auth_info_bytes: sign_doc.auth_info_bytes, | ||
| // The poorly documented trick to simuluating a tx without a valid signature is to just pass |
tkporter
merged commit a95d424
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
n/a
Related issues
n/a
Backward compatibility
yee
Testing
builds, local test