Cosmos cleanup 0 #2876
Merged
Cosmos cleanup 0 #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
approved these changes
Oct 31, 2023
| message: hex::encode(RawHyperlaneMessage::from(message)), | ||
| }, | ||
| }; | ||
| let payload = ModulesAndThresholdRequest::new(message); |
| pub message: String, // hexbinary | ||
| struct ModulesAndThresholdRequestInner { | ||
| /// Hex-encoded Hyperlane message | ||
| pub message: String, |
There was a problem hiding this comment.
one of my comments in the big PR is to stop using these strings entirely, curious to hear what you think
tkporter
merged commit 4583c9c
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
yorhodes
pushed a commit
that referenced
this pull request
Nov 2, 2023
### Description Addresses a handful of issues in #2865 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a handful of issues in #2865
Drive-by changes
Related issues
Backward compatibility
Testing