Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long validator name for polygonzkevmtestnet #2832

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Oct 23, 2023

Description

  • polygonzkevmtestnet's validator name was too long because of the controller-revision-hash label, see StatefulSet with long name can not create pods kubernetes/kubernetes#64023
  • Seeks to preserve the -validator suffix in the name, but truncates the earlier bit - in practice this results in validator pods like polygonzkevmtestnet-validator-hyperlane-ag-validator-0. This felt like the most backward compatible change -- of course we could consider trying to get a name like polygonzkevmtestnet-hyperlane-agent-validator-0 but this would break backward compatibility more dramatically because we'd need to change all the other validator pods. Imo we should just really avoid long chain names or consider a more breaking change to our infra

Drive-by changes

n/a

Related issues

n/a

Backward compatibility

Mostly

Testing

Deployed

@tkporter tkporter requested a review from daniel-savu as a code owner October 23, 2023 10:23
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2832 (1cebd20) into v3 (6769f55) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2832      +/-   ##
==========================================
- Coverage   61.86%   61.76%   -0.10%     
==========================================
  Files         100      100              
  Lines        1007     1007              
  Branches      104      104              
==========================================
- Hits          623      622       -1     
  Misses        347      347              
- Partials       37       38       +1     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 67.93% <ø> (ø)
isms 67.91% <ø> (-0.75%) ⬇️
token 55.44% <ø> (ø)
middlewares 73.17% <ø> (ø)

@tkporter tkporter merged commit b71050a into v3 Oct 23, 2023
17 of 19 checks passed
@tkporter tkporter deleted the trevor/fix-long-validator-names branch October 23, 2023 15:54
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants