Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still allow getting testnet3 secrets via externalsecrets, use mustFromJson in helm templates #2785

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Oct 6, 2023

Description

  • a single external-secrets instance lives on the cluster, and we are running testnet3 and testnet4 on the same cluster
  • json parsing errors were silently swallowed, moved to mustFromJson to prevent this

Drive-by changes

n/a

Related issues

Backward compatibility

Testing

@tkporter tkporter requested a review from daniel-savu as a code owner October 6, 2023 13:31
@tkporter tkporter changed the title still allow getting testnet3 secrets via externalsecrets still allow getting testnet3 secrets via externalsecrets, use mustFromJson in helm templates Oct 6, 2023
@nambrot nambrot merged commit e57d120 into testnet4-deploy Oct 10, 2023
7 checks passed
@nambrot nambrot deleted the trevor/fix-testnet4-monitoring branch October 10, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants