-
Notifications
You must be signed in to change notification settings - Fork 419
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(infra): ensure all supported chains per env have owners (#5125)
### Description fix(infra): ensure all supported chains per env have owners - add test - add missing chains ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing yarn test - tried with + without fix and observed that it correctly fails without the additional chains being added
- Loading branch information
1 parent
c690ca8
commit 335f57d
Showing
3 changed files
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { expect } from 'chai'; | ||
|
||
import { environments } from '../config/environments/index.js'; | ||
|
||
describe('Environment', () => { | ||
for (const env of Object.values(environments)) { | ||
it(`Has owners configured for ${env.environment}`, () => { | ||
for (const chain of env.supportedChainNames) { | ||
expect( | ||
env.owners[chain], | ||
`Missing owner for chain ${chain} in environment ${env.environment}`, | ||
).to.not.be.undefined; | ||
} | ||
}); | ||
} | ||
}); |