Skip to content

Commit

Permalink
fix(infra): ensure all supported chains per env have owners (#5125)
Browse files Browse the repository at this point in the history
### Description

fix(infra): ensure all supported chains per env have owners
- add test
- add missing chains

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

yarn test - tried with + without fix and observed that it correctly
fails without the additional chains being added
  • Loading branch information
paulbalaji authored Jan 8, 2025
1 parent c690ca8 commit 335f57d
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 0 deletions.
3 changes: 3 additions & 0 deletions typescript/infra/config/environments/mainnet3/owners.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,4 +243,7 @@ export const chainOwners: ChainMap<OwnableConfig> = {
osmosis: {
owner: 'n/a - nothing owned here',
},
soon: {
owner: 'n/a - nothing owned here',
},
};
6 changes: 6 additions & 0 deletions typescript/infra/config/environments/testnet4/owners.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,10 @@ export const owners: ChainMap<OwnableConfig> = {
]),
),
// [chainMetadata.solanadevnet.name]: SEALEVEL_DEPLOYER_ADDRESS,
eclipsetestnet: {
owner: 'n/a - nothing owned here',
},
solanatestnet: {
owner: 'n/a - nothing owned here',
},
};
16 changes: 16 additions & 0 deletions typescript/infra/test/environment.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { expect } from 'chai';

import { environments } from '../config/environments/index.js';

describe('Environment', () => {
for (const env of Object.values(environments)) {
it(`Has owners configured for ${env.environment}`, () => {
for (const chain of env.supportedChainNames) {
expect(
env.owners[chain],
`Missing owner for chain ${chain} in environment ${env.environment}`,
).to.not.be.undefined;
}
});
}
});

0 comments on commit 335f57d

Please sign in to comment.