Skip to content

Commit

Permalink
fix: neutron grpc url default; url parsing error message (#3466)
Browse files Browse the repository at this point in the history
### Description

The default neturon grpc url is plaintext but it was using a `http`
prefix so all requests would fail

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
  • Loading branch information
daniel-savu authored Mar 21, 2024
1 parent 176e710 commit 140e3c4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion rust/config/mainnet3_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@
],
"grpcUrls": [
{
"http": "https://grpc-kralum.neutron-1.neutron.org:80"
"http": "http://grpc-kralum.neutron-1.neutron.org:80"
}
],
"canonicalAsset": "untrn",
Expand Down
8 changes: 4 additions & 4 deletions rust/hyperlane-base/src/settings/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ fn parse_custom_urls(
.end()
.map(|urls| {
urls.split(',')
.filter_map(|url| url.parse().take_err(err, || &chain.cwp + "customGrpcUrls"))
.filter_map(|url| url.parse().take_err(err, || &chain.cwp + key))
.collect_vec()
})
}
Expand All @@ -440,12 +440,12 @@ fn parse_base_and_override_urls(

if combined.is_empty() {
err.push(
&chain.cwp + "rpc_urls",
eyre!("Missing base rpc definitions for chain"),
&chain.cwp + base_key,
eyre!("Missing base {} definitions for chain", base_key),
);
err.push(
&chain.cwp + "custom_rpc_urls",
eyre!("Also missing rpc overrides for chain"),
eyre!("Also missing {} overrides for chain", base_key),
);
}
combined
Expand Down

0 comments on commit 140e3c4

Please sign in to comment.