rm extra insuff check

hyperlane-xyz · Dec 13, 2024 · 139ba55 · 139ba55
1 parent bab9928
commit 139ba55
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/solidity/contracts/token/HypNative.sol b/solidity/contracts/token/HypNative.sol
@@ -76,7 +76,7 @@ contract HypNative is TokenRouter {
             _hookMetadata,
             _hook
         );
-        require(msg.value >= _amount + quote, "HypNative: insufficient value");
+        // require(msg.value >= _amount + quote, "HypNative: insufficient value");
 
         bytes memory hookMetadata = StandardHookMetadata.overrideMsgValue(
             _hookMetadata,

diff --git a/solidity/test/token/HypNative.t.sol b/solidity/test/token/HypNative.t.sol
@@ -88,8 +88,9 @@ contract HypNativeTest is HypTokenTest {
         assertEq(address(valueHook).balance, msgValue);
     }
 
-    function testRemoteTransfer_invalidAmount() public {
-        vm.expectRevert("HypNative: insufficient value");
+    // when msg.value is >= quote + amount, it should revert in
+    function testRemoteTransfer_insufficientValue() public {
+        vm.expectRevert();
         vm.prank(ALICE);
         localToken.transferRemote{value: TRANSFER_AMT}(
             DESTINATION,
@@ -134,7 +135,7 @@ contract HypNativeTest is HypTokenTest {
         hook.setFee(fee);
 
         vm.prank(ALICE);
-        vm.expectRevert("HypNative: insufficient value");
+        vm.expectRevert();
         localToken.transferRemote{value: msgValue - 1}(
             DESTINATION,
             BOB.addressToBytes32(),