-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SymonClient: Use Bree for Reporting to Symon #972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennypradipta
requested review from
ariya,
nicnocquee,
raosan,
ilmiawan,
haricnugraha,
kevin-hyperjump and
lukman7788
January 13, 2023 07:55
Whoops, broken test. Gonna turn it into draft for now |
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 45.20% 45.17% -0.04%
==========================================
Files 86 86
Lines 2920 2940 +20
Branches 587 588 +1
==========================================
+ Hits 1320 1328 +8
- Misses 1394 1408 +14
+ Partials 206 204 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ready for review |
sapiderman
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicnocquee
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monika Pull Request (PR)
What feature/issue does this PR add
This PR moves the reporting as a separate worker by using Bree.
How did you implement / how did you fix it
How to test
Additional Information
You may see a flow for modifying the report job like this:
This is because there is no built in function to modify current job (as explained in breejs/bree#169)