Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymonClient: Use Bree for Reporting to Symon #972

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

dennypradipta
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

This PR moves the reporting as a separate worker by using Bree.

How did you implement / how did you fix it

  1. Install Bree
  2. Moved the reporting process to a separate worker file

How to test

  1. Run Symon
  2. Run Monika in Symon Mode

Additional Information

You may see a flow for modifying the report job like this:

bree.remove()
bree.add()
bree.start()

This is because there is no built in function to modify current job (as explained in breejs/bree#169)

@dennypradipta
Copy link
Contributor Author

Whoops, broken test. Gonna turn it into draft for now

@dennypradipta dennypradipta marked this pull request as draft January 13, 2023 08:01
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #972 (30a2341) into main (c3b00dd) will decrease coverage by 0.03%.
The diff coverage is 44.23%.

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   45.20%   45.17%   -0.04%     
==========================================
  Files          86       86              
  Lines        2920     2940      +20     
  Branches      587      588       +1     
==========================================
+ Hits         1320     1328       +8     
- Misses       1394     1408      +14     
+ Partials      206      204       -2     
Impacted Files Coverage Δ
src/symon/index.ts 61.14% <44.23%> (-3.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dennypradipta dennypradipta marked this pull request as ready for review January 16, 2023 07:02
@dennypradipta
Copy link
Contributor Author

Ready for review

Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽 💪🏽

reporting works

image

@nicnocquee nicnocquee merged commit 0e782c0 into hyperjumptech:main Jan 20, 2023
This was referenced Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants