Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: switch version to last released version #2047

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Nov 13, 2024

Motivation

As part of #2014, the versions of "tonic" and "tonic-build" were changed to 0.13. This breaks the instuctions in the examples documentation with an error like:

helloworld_tonic$ cargo run --bin helloworld-server
    Updating crates.io index
error: failed to select a version for the requirement `tonic = "^0.13"`
candidate versions found which didn't match: 0.12.3, 0.12.2, 0.12.1, ...
location searched: crates.io index
required by package `helloworld-tonic v0.1.0 (/usr/local/google/home/easwars/src/rust/projects/helloworld_tonic)`
if you are looking for the prerelease package it needs to be specified explicitly
    tonic = { version = "0.1.0-beta.1" }

Solution

This PR changes the version of "tonic" and "tonic-build" to * which results in the latest version getting picked. Setting it to * also has the nice property of not having to update the examples everytime a version bump is required.

As part of hyperium#2014, the versions of
"tonic" and "tonic-build" were changed to "0.13". This breaks the
instuctions in the examples documentation with an error like:
```
helloworld_tonic$ cargo run --bin helloworld-server
    Updating crates.io index
error: failed to select a version for the requirement `tonic = "^0.13"`
candidate versions found which didn't match: 0.12.3, 0.12.2, 0.12.1, ...
location searched: crates.io index
required by package `helloworld-tonic v0.1.0 (/usr/local/google/home/easwars/src/rust/projects/helloworld_tonic)`
if you are looking for the prerelease package it needs to be specified explicitly
    tonic = { version = "0.1.0-beta.1" }
```

This PR changes the version of "tonic" and "tonic-build" to "*" which
results in the latest version getting picked. Setting it to "*" also has
the nice property of not having to update the examples everytime a
version bump is required.
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is unrelated, ill take a look at it

@LucioFranco LucioFranco added this pull request to the merge queue Nov 14, 2024
Merged via the queue into hyperium:master with commit eb66b91 Nov 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants