Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Remove timeout from tower example #2030

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 30, 2024

As tower's timeout service is not recommended for setting timeout in tonic, removes it to reduce possibility of confusion. I feel the tower example is explanatory without it.

@tottoto tottoto force-pushed the remove-timeout-from-tower-example branch from cb1604e to 1dbe01b Compare November 5, 2024 11:25
@tottoto tottoto force-pushed the remove-timeout-from-tower-example branch from 1dbe01b to f624ac4 Compare November 6, 2024 13:57
@tottoto tottoto added this pull request to the merge queue Nov 6, 2024
Merged via the queue into hyperium:master with commit b80428b Nov 6, 2024
17 checks passed
@tottoto tottoto deleted the remove-timeout-from-tower-example branch November 6, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant