Update base64 dependency from 0.21 to 0.22 #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: cargo build; cargo test
djc
approved these changes
Apr 25, 2024
|
Would be nice to have! |
|
Duplicate of #1649. |
|
Merged #1649 so closing this thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tonic currently depends on two different versions of base64 - directly on 0.21, and transitively through rustls-pemfile on 0.22. Updating tonic to use 0.22 results in just a single version dependency. This is helpful for ecosystems (like Android) where keeping crates on the latest version of dependencies across various projects helps reduce memory usage and disc space.