Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tonic): Remove API when they only return None #1584

Merged

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Dec 9, 2023

Motivation

Continues #1520 and resolves #1516.

Solution

Warning

This proposal includes breaking changes.

Removes APIs when they only return None.

@tottoto tottoto force-pushed the remove-api-when-they-only-return-none branch 2 times, most recently from fdf0462 to c1443e2 Compare December 9, 2023 21:21
@tottoto tottoto force-pushed the remove-api-when-they-only-return-none branch from 1870ba1 to d92cf01 Compare December 9, 2023 21:32
@LucioFranco LucioFranco added this pull request to the merge queue Dec 19, 2023
Merged via the queue into hyperium:master with commit 4077ab0 Dec 19, 2023
15 of 16 checks passed
@tottoto tottoto deleted the remove-api-when-they-only-return-none branch December 19, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove APIs which only return None at specific feature from the feature
2 participants