Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include origin path when preparing request #1562

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Include origin path when preparing request #1562

merged 2 commits into from
Nov 15, 2023

Conversation

kariy
Copy link
Contributor

@kariy kariy commented Oct 31, 2023

Motivation

when creating a Grpc type using Grpc::with_origin, the path of the origin is not included in the requests

attempting to solve a somewhat similar issue with #1314

Solution

at the prepare_request stage, combine the path of the origin and the request path

I'm not sure if this is the correct way of solving the issue.

@LucioFranco LucioFranco added this pull request to the merge queue Nov 15, 2023
Merged via the queue into hyperium:master with commit 07e4ee1 Nov 15, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kariy @LucioFranco