Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transport): Replace axum with matchit #1561

Closed
wants to merge 1 commit into from

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 30, 2023

Motivation

Simplifies dependency tree, and implementations. axum seems to be a relatively too large library for the purpose of implementing tonic's router. Directly using matchit, which is a crate used in axum seems to be simple for tonic.

Solution

warning
This proposal contains breaking changes.

Replaces axum with matchit to implement the router.

@tottoto tottoto force-pushed the replace-axum-with-matchit branch from ea7f8ac to 303a4d7 Compare October 30, 2023 15:00
@LucioFranco
Copy link
Member

So I've actually been using the axum support a lot https://github.com/tursodatabase/libsql/blob/main/libsql-server/src/http/user/mod.rs#L417 for example there. So I think we if we move to matchit we loose this ability to mix and match?

@tottoto tottoto force-pushed the replace-axum-with-matchit branch from 303a4d7 to 164282d Compare November 14, 2023 13:08
@tottoto
Copy link
Collaborator Author

tottoto commented Nov 15, 2023

I think so. axum's router seems not to be able to be got from the matchit's one by the user side.

@LucioFranco
Copy link
Member

I think so. axum's router seems not to be able to be got from the matchit's one by the user side.

Yeah then lets keep it how it is for now. its quite useful to use the axum router actually ive found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants