chore(transport): Deprecate re-exported NamedService #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
deprecate-re-exported-named-service
branch
from
11cfd09 to
875fd22
Compare
tottoto
force-pushed
the
deprecate-re-exported-named-service
branch
from
875fd22 to
4c7f2f5
Compare
tottoto
force-pushed
the
deprecate-re-exported-named-service
branch
from
4c7f2f5 to
b0c0597
Compare
LucioFranco
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removes old API.
Solution
NamedServicehas been re-exported in transport module for the historical reason. The re-exporting could be removed. Asdeprecateddoes not handle re-export, the deprecation should be at the comment.